Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement container execution #38

Closed
satra opened this issue Dec 21, 2018 · 5 comments
Closed

Implement container execution #38

satra opened this issue Dec 21, 2018 · 5 comments

Comments

@satra
Copy link
Contributor

satra commented Dec 21, 2018

Related to #32

Minimal task support currently merged. should be extended to provide complete isolation. i should be able to run the pydra workflow itself in one container, and have it launch other tasks inside that container or in remote containers (through slurm, aws, dind, singularity, etc.,.)

@satra
Copy link
Contributor Author

satra commented Apr 6, 2019

  • run entire workflow using one container

  • run FunctionTask in a container

  • run each task and sub workflows using the prescribed container for the workflow

  • run each task in its own prescribed container

  • propagate new environment from one task to next

  • add semantics for overrides both downstream and upstream (may result in exceptions when in conflict

@satra satra added this to the 0.2 milestone Aug 18, 2019
@djarecka
Copy link
Collaborator

djarecka commented Feb 3, 2020

  • propagate new environment from one task to next
  • propagate new environment from one task to next

do you mean passing image? Image is an input, so you can a make connection

  • add semantics for overrides both downstream and upstream (may result in exceptions when in conflict

could you please elaborate

@satra
Copy link
Contributor Author

satra commented Feb 4, 2020

i think these two tasks could be punted for later.

yes, the first one would allow setting the environment of a subsequent task from the output of a previous task. something like.

task2.image = task1.lzout.image

for downstream and upstream this gets more complicated. let's say i set the workflow to run tasks using a container. should this override the container of a subtask that has an explicit container? so we need options for workflow overrides task, or task overrides workflow.

@djarecka djarecka modified the milestones: 0.3 - Attr++ enhancements, 0.4 - Leap day release Feb 8, 2020
@djarecka
Copy link
Collaborator

djarecka commented Feb 8, 2020

#202 shows that the image can be treated as any other input, so can be also part of the connection.

I've added one more point - FunctionTask with a container has to be done before we can propagate image to each task of the wf

@satra satra modified the milestones: 0.4 - Leap day release, 0.5 - Fool's day release Mar 3, 2020
@djarecka djarecka modified the milestones: 0.5 May Day, 0.6 - June bug May 4, 2020
@djarecka
Copy link
Collaborator

for now we are not working for this anymore, will keep the missing points for later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants