Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please post any comments on the pydra notebooks here. #147

Open
satra opened this issue Aug 29, 2019 · 9 comments
Open

Please post any comments on the pydra notebooks here. #147

satra opened this issue Aug 29, 2019 · 9 comments

Comments

@satra
Copy link
Contributor

satra commented Aug 29, 2019

we would like to collect feedback in one place. if you test things out yourself or through binder, please post any comments here.

@satra satra added the question Further information is requested label Aug 29, 2019
@satra satra mentioned this issue Aug 29, 2019
2 tasks
@tsalo
Copy link

tsalo commented Nov 15, 2019

I didn't see any examples of tasks made from imported functions (rather than decorators applied at function definition) in the notebooks. For example, to create a task for the import function numpy.fft.fft, you need to do:

# To convert an existing function into a task
# NOTE: Does not work with ufuncs
import numpy as np
import pydra
fft = pydra.mark.annotate({'a': np.ndarray, 'return': float})(np.fft.fft)
fft = pydra.mark.task(fft)

@djarecka
Copy link
Collaborator

@tsalo - thank you! will add it!

@oesteban oesteban added documentation and removed question Further information is requested labels Jan 4, 2020
@satra
Copy link
Contributor Author

satra commented Jan 28, 2020

@djarecka - has this been added to the tutorial? if so please close this.

@djarecka
Copy link
Collaborator

I will

@nicolocin
Copy link
Collaborator

Can't run DockerTask in the intro_shelltask.py tutorial. Docker not install properly? Pretty sure it was working at some point.

Screen Shot 2020-04-19 at 4 15 46 PM

@jsmentch
Copy link
Contributor

I also ran into the same bug as @nicolocin. I'm going through the binder notebooks and everything worked up until DockerTask

@djarecka
Copy link
Collaborator

Thanks @nicolocin and @jsmentch . I'm updating the tutorials and will make sure that this works!

@djarecka
Copy link
Collaborator

actually this example will not work with binder, have to make this clear. At least the current docker container we're using with binder doesn't run docker inside.

@nicolocin - you didn't say where are you running the notebook. Could you please confirm that this was with binder as well?

@nicolocin
Copy link
Collaborator

@djarecka yes got that error on binder! If it doesn't work with binder should we exclude that from the tutorial then? Or at least a note saying that for now DockerTask only works locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants