Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What happens when self.select() returns size 0? #10

Open
ninehusky opened this issue Feb 19, 2025 · 0 comments
Open

What happens when self.select() returns size 0? #10

ninehusky opened this issue Feb 19, 2025 · 0 comments

Comments

@ninehusky
Copy link
Owner

I think this is probably fine; I just want to merge a PR and don't want to dig to the bottom of this. hashtag bias for action.

Anyways: I had to put a check here which says "do nothing" if self.select().is_empty(). Is this expected behavior?

This check doesn't exist in the total ruleset synthesis because it probably doesn't matter; we don't need to unwrap that latest rule which was added and do the condition checking in that case. But because we do need to unwrap in the conditional case, this causes problems when select returns an empty set. We should see if this is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant