Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Independent deposit #10

Closed
ninegua opened this issue Nov 23, 2023 · 0 comments
Closed

Independent deposit #10

ninegua opened this issue Nov 23, 2023 · 0 comments

Comments

@ninegua
Copy link
Owner

ninegua commented Nov 23, 2023

The previous design of cycle deposit process was synchronized with other cycle related activities (e.g. canister top-up or other deposits) because we had no easy way of calculating how much cycle was deposited by converting from ICP.

But this has changed with the new CMC canister interface. The method notify_top_up(..) now returns the actual amount of cycles sent to the tipjar canister (after depositing user's ICP). So this means the deposit process can be made independent and it is safe to run concurrently too. As a result the we'll have a more simplified and streamlined process.

@ninegua ninegua closed this as completed Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant