Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log validator address #3100

Open
paberr opened this issue Nov 19, 2024 · 2 comments
Open

Log validator address #3100

paberr opened this issue Nov 19, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@paberr
Copy link
Member

paberr commented Nov 19, 2024

We should extend logging in many places (especially for wrong signatures) and include the validator address.
Also, whenever we log something about slots, we should include the validator address.

This will make it easier to identify validators with an erroneous setup.

@paberr paberr added the enhancement New feature or request label Nov 19, 2024
@blouflashdb
Copy link

Will this leak the ip address of the validator? If so i would very dislike this change.

@sisou
Copy link
Member

sisou commented Nov 25, 2024

No, validator address here means the Nimiq address (NQ...), to better identify which validator a log message is talking about. Currently it just logs the unlegible peer address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants