Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gringotts-Towny takes my gold but doesnt depoist it with /t depoist #4

Open
22Conner opened this issue Oct 17, 2022 · 16 comments
Open
Assignees

Comments

@22Conner
Copy link

2022-10-16.22-42-12.mp4
@nikosgram nikosgram self-assigned this Oct 18, 2022
@nikosgram
Copy link
Owner

Looking into it :)

@x390
Copy link

x390 commented Oct 29, 2022

Having the same issue with creating a new town. Takes the gold then says you can't afford to settle a new town.

@spikehidden
Copy link

I have the same issue and I assume it is the answer time of Gringrotts?
I mean I actually have no clue but I noticed that if you really have no money the message "There is not enough money in the bank." comes a lot quicker.

Or maybe it has to do with Towny's changes of der CancelationEvent. I don't know.

Interesting is though that the bankhistory gets updated on withdrawal but of course you don't get anything the money is just gone.

Taxes and Upkeep payment also seems to work so it seems not to have an issue of retrieving the amount that is stored in the vaults.

As this seems to be an issue only on the player interaction side could it be that this might be a bug on Towny's side with the interaction with vault? Unless of course you bypass Vault and interact with Towny's API directly for player economy interactions.

I wonder if it might had to do with the Towny Addon Plugins (SiegeWars, TownyResources). I doubt it though. But when I tested that I come back.

Whatever, I hope my thoughts help. Probably not. 😅

P.S.: Also effects /n deposit|withdraw {$}

@spikehidden
Copy link

(Possible "Workaround" at the end.)

I don't know if it helps but the following things seem to affected or not:

Affected

  • Town Creation
  • Nation Creation
  • Town/Nation Withdrawing
  • Town/Nation Depositing

Unaffected

  • Taxes
  • Upkeep

Also the mentioned Plugins do not cause this issue.

Cause?

As of writing this I was testing around and I'm 99% sure to have found what the issue is.\

If you set economy.closed_economy.enabled to true and try to put a nation or town account at economy.closed_economy.server_account the problem appears but if I put a player in there or an account that cannot exist it does not happen.

Ex.:

economy:
  closed_economy:
    server_account: town:my_town
    enabled: 'true'

I assume that Gringotts doesn't answer when Towny tries to check that account? idk 🤷‍♂️

Workaround

Well for anyone reading this because they have the same issue deactivate the feature or use it with a (fake) player.
You could also create a fake player by deactivating online-mode joining with a player that starts with # and then restart your server with activated online-mode. There you have your fake player account that works with Gringotts.

@brandcrystal
Copy link

Any update on this fix? Really wanting to use this, thanks.

@ponkersboard
Copy link

any update? @nikosgram I want to use gringotts with towny but this makes it unusable :)

@GroobleDierne
Copy link
Contributor

Do you get an error in the console?

@JuniperTree4Me
Copy link

Separate person, same issue, yes I do. (See image attached)

It's "java.lang.BoClassDefFoundError: org/gester/gringotts/api/dependency/Dependency"
Searching through the .jar, I see no reference to that in the "org" folder.

image

@GroobleDierne
Copy link
Contributor

Separate person, same issue, yes I do. (See image attached)

It's "java.lang.BoClassDefFoundError: org/gester/gringotts/api/dependency/Dependency" Searching through the .jar, I see no reference to that in the "org" folder.

image

Are you sure you installed both Gringotts-towny and Gringotts ?

@nikosgram
Copy link
Owner

It might be the case that Gringotts is not part of the plugins. Gringotts-Towny requires both Gringotts and Vault to properly function.

Can you verify that both of those plugins are part of your plugins?

@JuniperTree4Me
Copy link

JuniperTree4Me commented Jun 16, 2023 via email

@nikosgram
Copy link
Owner

We currently waiting for 1.20 ecosystem to get a bit robust before we decide to start supporting it. Although, feel free to give it a try and report any issues. :)

BTW, A full list of the plugins installed, if possible, would be incredible helpful.

@Asuniia
Copy link

Asuniia commented Jun 27, 2023

same issue in 1.20.1

@nikosgram
Copy link
Owner

Is it possible to reproduce it with the latest version of Gringotts? :) If you haven't already.

@ponkersboard
Copy link

We currently waiting for 1.20 ecosystem to get a bit robust before we decide to start supporting it. Although, feel free to give it a try and report any issues. :)

BTW, A full list of the plugins installed, if possible, would be incredible helpful.

this got forgotten or no?
@nikosgram

@ponkersboard
Copy link

There is no issue in console
and the money just dissapears
PLEASE!! FIX ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants