Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using .url() on page object results in "expression is not callable, Type 'String' has no call signatures." typescript error #3903

Open
reallymello opened this issue Aug 31, 2023 · 12 comments · May be fixed by #4068
Open

Using .url() on page object results in "expression is not callable, Type 'String' has no call signatures." typescript error #3903

reallymello opened this issue Aug 31, 2023 · 12 comments · May be fixed by #4068
Labels
good first issue hacktoberfest typescript-types-declaration Issues to related to Typescript types

Comments

@reallymello
Copy link
Contributor

reallymello commented Aug 31, 2023 •
edited

Description of the bug/issue

When I use myPageObject.url() I expect the string generated/returned by the url function in my page object to be returned, but instead I receive a TypeScript error "expression is not callable, Type 'String' has no call signatures." though it does return the string.

I think the types need to be updated to reflect that .url can be a string or a function type. I think calling .url should work for when the url property in the page object is a string and .url() should return the result of the url parameter when it is defined as a function.

image

image

Steps to reproduce

const myPageObject: PageObjectModel = {
  url: function(this: myPageObject) {
    return `https://${baseUrl}/index.aspx`;
  }
}

Sample test

const myPageObject = browser.page.myPageObject();
console.log(myPageObject.url());

Command to run

npx nightwatch

Verbose Output

n/a TypeScript error in IDE only

Nightwatch Configuration

n/a TypeScript error in IDE only

Nightwatch.js Version

3.1.3

Node Version

18.5

Browser

Chrome 115

Operating System

Windows 11

Additional Information

No response
@gravityvi gravityvi added the typescript-types-declaration Issues to related to Typescript types label Sep 1, 2023
@Tanush-J
Copy link

Tanush-J commented Oct 5, 2023

I will give this a try

@NithinSravan
Copy link

Hi @AutomatedTester ! I would love to take up this task. Can you please assign it to me? I would love to start my opensource journey here.

@gravityvi
Copy link
Member

@NithinSravan Sure go ahead.

@AutomatedTester
Copy link
Member

AutomatedTester commented Oct 13, 2023 via email

@garg3133
Copy link
Member

garg3133 commented Feb 22, 2024 •
edited

To reproduce this issue, clone https://github.com/garg3133/nightwatch-typescript-boilerplate repository (nightwatch-v3 branch) and then inside test/dropdown.ts, add console.log(dropDownPage.url()) anywhere inside the it block.

@Gmin2
Copy link

Gmin2 commented Feb 24, 2024

Working on it @garg3133

@garg3133 garg3133 mentioned this issue Feb 24, 2024
Closed
@garg3133
Copy link
Member

Sure @Min2who, you can start with investigating this issue and suggest a potential solution.

@piyushmishra1416
Copy link

Hello @garg3133, I have been working on this issue since yesterday, I tried to reproduce the issue as you mentioned above
comment. I cloned the repo and initially while running the test using npm run test, I faced a Chromedriver version mismatch error.

error: 'session not created',
message: 'session not created: This version of ChromeDriver only supports Chrome version 103\n'

I fixed the issue by upgrading the Chromedriver to the latest version using npm install chromedriver@latest --save-dev. This resolved the error and allowed me to run the tests successfully.

Following your instructions, I added console.log(dropDownPage.url()) to src/dropdown.ts. However, I encountered a name mismatch error, which I resolved by changing the name to console.log(dropdown.url());. Despite this, I did not encounter any TypeScript errors.
Also, I am seeing a difference, the owner of the issue is using myPageObject type, and https://github.com/garg3133/nightwatch-typescript-boilerplate this repo is using EnhancedPageObject type. I also tried to import the myPageObject from the nightwatch in the same repo but it says module not found.
Is there any step that I have missed while reproducing the issue?
image

@Gmin2
Copy link

Gmin2 commented Feb 24, 2024 •
edited

clone the nightwatch-v3 branch

@Gmin2
Copy link

Gmin2 commented Feb 24, 2024 •
edited

Hey @garg3133

export type EnhancedPageObject<
  Commands = {},
  Elements = {},
  Sections extends Record<string, PageObjectSection> = {},
  Props = {},
  URL = string
>

changing the type of URL in in page-object.d.ts will solve this problem

export type EnhancedPageObject<
  Commands = {},
  Elements = {},
  Sections extends Record<string, PageObjectSection> = {},
  Props = {},
  URL = string | (() => string)
>

should i proceed with making a pr for this

@piyushmishra1416
Copy link

I am now able to reproduce the issue. Thanks @Min2who for providing the fix.
I think the actual type for the URL will be URL = string | ((...args: any) => string) but not sure. Can you please confirm on this @garg3133 ?

@piyushmishra1416
Copy link

Hello @garg3133, could you assign this issue to me if the solution provided in comment is viable?

@piyushmishra1416 piyushmishra1416 linked a pull request Feb 28, 2024 that will close this issue
Draft
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue hacktoberfest typescript-types-declaration Issues to related to Typescript types
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

updated URL type piyushmishra1416/nightwatch
8 participants
@AutomatedTester @reallymello @gravityvi @garg3133 @NithinSravan @Tanush-J @piyushmishra1416 @Gmin2