Skip to content

Commit 378a2e1

Browse files
committed
Update to version 1.3.0. Uses pylint 1.8.
1 parent fade84a commit 378a2e1

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

python_ta/checkers/global_variables_checker.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
from pylint.checkers import BaseChecker
55
import astroid
66
import re
7-
from pylint.checkers.base import CONST_NAME_RGX
7+
from pylint.checkers.base import SnakeCaseStyle
88

99

1010
class GlobalVariablesChecker(BaseChecker):
@@ -70,10 +70,13 @@ def _inspect_vars(self, node):
7070
def _get_child_disallowed_global_var_nodes(node):
7171
"""Return a list of all top-level Name or AssignName nodes for a given
7272
global, non-constant variable.
73+
74+
TODO: use the configured NamingStyle instead of hard-coded SnakeCaseStyle
75+
for the CONST_NAME_RGX value.
7376
"""
7477
node_list = []
7578
if ((isinstance(node, (astroid.AssignName, astroid.Name)) and not isinstance(node.parent, astroid.Call)) and
76-
not re.match(CONST_NAME_RGX, node.name) and
79+
not re.match(SnakeCaseStyle.CONST_NAME_RGX, node.name) and
7780
node.scope() is node.root()):
7881
return [node]
7982

setup.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ def readme():
1111

1212
setup(
1313
name='python-ta',
14-
version='1.2.3',
14+
version='1.3.0',
1515
description='Code checking tool for teaching Python',
1616
long_description=readme(),
1717
url='http://github.com/pyta-uoft/pyta',
@@ -22,11 +22,11 @@ def readme():
2222
'python_ta.docstring', 'python_ta.patches', 'python_ta.parser',
2323
'python_ta.transforms', 'python_ta.typecheck'],
2424
install_requires=[
25-
'astroid>=1.5.3',
25+
'astroid>=1.6',
2626
'funcparserlib',
2727
'hypothesis',
2828
'pycodestyle',
29-
'pylint>=1.7',
29+
'pylint>=1.8',
3030
'nose',
3131
'colorama',
3232
'six',

0 commit comments

Comments
 (0)