Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

not installable on mac M1 machine #106

Open
grimmer0125 opened this issue Oct 26, 2021 · 2 comments · May be fixed by #110
Open

not installable on mac M1 machine #106

grimmer0125 opened this issue Oct 26, 2021 · 2 comments · May be fixed by #110

Comments

@grimmer0125
Copy link
Collaborator

grimmer0125 commented Oct 26, 2021 •
edited

The output log is:

gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
  TOUCH Release/obj.target/libvips-cpp.stamp
  CC(target) Release/obj.target/nothing/node_modules/node-addon-api/nothing.o
  LIBTOOL-STATIC Release/nothing.a
warning: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: archive library: Release/nothing.a the table of contents is empty (no object file members in the library define global symbols)
  CXX(target) Release/obj.target/sharp/src/common.o
../src/common.cc:24:10: fatal error: 'vips/vips8' file not found
#include <vips/vips8>
         ^~~~~~~~~~~~
1 error generated.
make: *** [Release/obj.target/sharp/src/common.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/grimmer/.nvm/versions/node/v15.14.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:194:23)
gyp ERR! stack     at ChildProcess.emit (node:events:369:20)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (node:internal/child_process:290:12)
gyp ERR! System Darwin 20.6.0
gyp ERR! command "/Users/grimmer/.nvm/versions/node/v15.14.0/bin/node" "/Users/grimmer/.nvm/versions/node/v15.14.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/grimmer/git/webpack-demo/node_modules/sharp
gyp ERR! node -v v15.14.0
gyp ERR! node-gyp -v v7.1.2
gyp ERR! not ok

@nicolaspanel ,
another related thing is, I forked this repo to mine and consider to release a TypeScript version as another npm package, one of the reasons is that I remove the image manipulation feature. The changes are here, grimmer0125/numjs#4 and I do not change the algorithm part.

Should you have any concerns and suggestions, please tell me.
@nicolaspanel
Copy link
Owner

hi @grimmer0125
I just gave you write access to this repo => Feel free to improve it in any way
1 advice though: sticking to numpy api (or as close as possible) make it easier for numpy users
Best regards

@grimmer0125 grimmer0125 linked a pull request Dec 22, 2021 that will close this issue
Open
@rawpixel-vincent
Copy link

rawpixel-vincent commented Jun 23, 2022 •
edited

see #125 that fixes this issue
in the meantime, adding to your project package.json:

  "resolutions": {
    "sharp": "0.30.7" // or 0.29.3
  },

should fix the issue

you can also reference the PR in your dependencies:

  "dependencies": {
    "numjs": "nicolaspanel/numjs#pull/125/head",

ref issue #122

@rawpixel-vincent rawpixel-vincent mentioned this issue Jun 23, 2022
Open
@DaveFlashNL DaveFlashNL mentioned this issue Jan 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update dependent sharp package to fix its m1 (arm64) compatibility issue grimmer0125/numjs-1
3 participants
@nicolaspanel @grimmer0125 @rawpixel-vincent