Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Other padding modes for convolve #105

Open
awillats opened this issue Oct 16, 2021 · 0 comments
Open

Feature Request: Other padding modes for convolve #105

awillats opened this issue Oct 16, 2021 · 0 comments

Comments

@awillats
Copy link

Currently only the 'valid' mode of convolution is supported. I'd like to help add support for the 'same' and 'full' padding modes included in most other implementations of convolution:

visual explanation of convolution padding modes
matlab implementation
numpy implementation
a little more discussion

I've hacked together something simple for the problem I have that implements this, (and verified it against numpy's implementation) so I'm happy to help with a pull request! But I'd need a little help formatting it in a clean consistent way (not sure how to set up the spec.js etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant