Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

PR: Add support for eslint-plugin-compat #43

Closed
amilajack opened this issue Jan 2, 2017 · 5 comments
Closed

PR: Add support for eslint-plugin-compat #43

amilajack opened this issue Jan 2, 2017 · 5 comments

Comments

@amilajack
Copy link
Contributor

amilajack commented Jan 2, 2017 •
edited
Loading

This eslint plugin lints against APIs that are only supported by target browsers 馃帀 Would a PR for this be welcome?

Here's a demo of it in action

demo of plugin usage
@nicksp
Copy link
Owner

nicksp commented Feb 10, 2017

Hey @amilajack

Sorry for the delay in response. Been busy with projects....
Yeah it looks really nice and i'd like to have it as PR for my boilerplate, which i'm going to significantly update in several next days...

@nicksp nicksp closed this as completed Feb 10, 2017
@nicksp nicksp reopened this Feb 21, 2017
@nicksp
Copy link
Owner

nicksp commented Feb 21, 2017

@amilajack Do you think you'll have a chance to submit PR?

@amilajack
Copy link
Contributor Author

Sure thing!

@amilajack
Copy link
Contributor Author

Having trouble doing this because i'm not used to the kinds of configuration setup this project uses. I also cant seem to run the test correctly because they keep failing

@nicksp
Copy link
Owner

nicksp commented Feb 22, 2017

@amilajack You can skip tests for now, as i said in README they fail and am rewriting them atm to the setup i'm more used to. If you need help with anything else, just let me know.

@nicksp nicksp closed this as completed Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicksp @amilajack