Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question of relative pose in matching augmentation. #61

Open
JarvisLee0423 opened this issue Oct 18, 2022 · 1 comment
Open

Question of relative pose in matching augmentation. #61

JarvisLee0423 opened this issue Oct 18, 2022 · 1 comment

Comments

@JarvisLee0423
Copy link

Hi, after I look through the codes of the many depth, I found a confused part when doing the matching augmentation. When you try to solve the static camera problem, you replace the frame -1 to be the color augmented version of frame 0. However, in the code, it seems that you only change the rgb from frame -1 to frame 0, the pose is still the relative pose between frame -1 and frame 0. Therefore this original relative pose will be used to compute the cost volume. Whereas, I think it is a little bit unreasonable, because in this case, when you compute the cost volume, the two frame will be augmented frame 0 and frame 0, whose relative pose should be identity matrix, but, in practical, the corresponding relative pose is between frame -1 and frame 0. It is confused for me. Looking forward to your explain.

@DavidYan2001
Copy link

Hi, I find the same question, have you solved this?
Btw, I suppose that the static camera aug and missing cost volume aug can be combined as one aug because we only need to set the pose=0, and input frame 0 and frame 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants