Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Nhost v2 #51

Closed
2 of 4 tasks
shyndman opened this issue Jan 27, 2022 · 13 comments · Fixed by #50
Closed
2 of 4 tasks

Add support for Nhost v2 #51

shyndman opened this issue Jan 27, 2022 · 13 comments · Fixed by #50
Assignees
Labels
enhancement New feature or request

Comments

@shyndman
Copy link
Contributor

shyndman commented Jan 27, 2022

Beta is out the door. Work remaining:

  • Evaluate the need for _loading in AuthService
  • Add missing sign in methods
  • Review backend endpoint by endpoint, ensuring we have support
    • Resend e-mail verification process/e-mail
@shyndman shyndman added the enhancement New feature or request label Jan 27, 2022
@shyndman shyndman self-assigned this Jan 27, 2022
@shyndman shyndman linked a pull request Jan 27, 2022 that will close this issue
@shyndman shyndman pinned this issue Jan 27, 2022
@shyndman
Copy link
Contributor Author

Not quite ready to close yet.

@shyndman shyndman reopened this Jan 28, 2022
@shyndman
Copy link
Contributor Author

Just published #50 to pub. Here are the new versions:

nhost_sdk                3.0.0-beta.0
nhost_gql_links          2.0.0-beta.0
nhost_flutter_auth       2.0.0-beta.0
nhost_graphql_adapter    2.0.0-beta.0
nhost_flutter_graphql    2.0.0-beta.0

This is still a work in progress, but I'm going to be knocking off what's missing over the coming days, and continue to cut beta releases as I do so.

@shyndman
Copy link
Contributor Author

shyndman commented Feb 1, 2022

New set of packages out the door, including the changes in #57 and #58.

nhost_sdk                3.0.0-beta.1
nhost_gql_links          2.0.0-beta.1
nhost_flutter_auth       2.0.0-beta.1
nhost_graphql_adapter    2.0.0-beta.1
nhost_flutter_graphql    2.0.0-beta.1

@MaxSchilling
Copy link

Hi @shyndman, Johan said that V2 will offer an endpoint to retrieve the e-mail verification process/e-mail, is that already covered within the new sdk as method? Thanks!

@shyndman
Copy link
Contributor Author

Hey @MaxSchilling,

It is not. Let me take a look at getting this in.

@shyndman
Copy link
Contributor Author

To be clear, you're looking to retrieve the text of the verification email?

@shyndman
Copy link
Contributor Author

If you're looking for the ticket used to verify the email address, it's stored in the auth.users table, and can be accessed via gql. Keep in mind that the permissions will have to be set up appropriately to modify view/modify the value.

@MaxSchilling
Copy link

Hey Scott,
no actually a method to re-trigger the actual email-verification mail from the server, as the account activation ticket (that is created on registration) expires after 60 minutes.
As I understood Johan in V2 there is a way/endpoint to retrigger the token and trigger the activation mail for the user again. This wasn't possible in v1 and we lost quite some users through missing that functionality / not activating within 60 minuted.

So would be great to provide that functionality.

Bonus would be if the authenticationState could reflect wether the user activated the account yet, would make the routing easier to route to a re-send verification screen / functionality.

@shyndman
Copy link
Contributor Author

Got it.

@elitan, which endpoint is @MaxSchilling referring to?

@elitan
Copy link
Contributor

elitan commented Feb 22, 2022

@shyndman This one: https://github.com/nhost/nhost/blob/main/packages/hasura-auth-js/src/hasura-auth-api.ts#L149

@shyndman
Copy link
Contributor Author

Thanks! Got that in.

I'm publishing a new set of packages now. Here are the versions:

nhost_sdk                3.0.0-beta.3
nhost_flutter_auth       2.0.0-beta.3
nhost_gql_links          2.0.0-beta.3
nhost_graphql_adapter    2.0.0-beta.3
nhost_flutter_graphql    2.0.0-beta.3

@shyndman
Copy link
Contributor Author

Packages are now graduated to stable:

nhost_sdk                3.0.0
nhost_gql_links          2.0.0
nhost_graphql_adapter    2.0.0
nhost_flutter_auth       2.0.0
nhost_flutter_graphql    2.0.0

@diegonc
Copy link

diegonc commented Nov 29, 2022

Evaluate the need for _loading in AuthServiceClient

I just did a quick search on the auth_client.dart file and the _loading flag is never set to true.
Thus, the authentication state inProgress is never returned.

@mhadaily mhadaily assigned mhadaily and unassigned shyndman Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants