Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong file revisions are taken in code review #72

Open
arturaz opened this issue Jun 1, 2020 · 3 comments · May be fixed by #82
Open

Wrong file revisions are taken in code review #72

arturaz opened this issue Jun 1, 2020 · 3 comments · May be fixed by #82

Comments

@arturaz
Copy link

arturaz commented Jun 1, 2020

We're trialing your plugin and it seems it's pointing to wrong commits when doing a merge request review.

Your plugin:
image

image

image

Whereas if I compare things from Idea (git > compare branches), I get the correct commit IDs.

image

$ git rev-parse origin/master
65ba49757fb5f2159f130db9e646224d5cd7cb42

$ git rev-parse feature/addressables
c1b4e93f0b92a017af787d5f0b350eda65efac35
@jackbentley
Copy link

Seem to be having a similar issue. From my perspective, it seems like it's not updating when there's been a change to the target branch

@jackbentley jackbentley linked a pull request Jul 20, 2020 that will close this issue
Open
@Nico04
Copy link

Nico04 commented Oct 16, 2020

Same issue here +1

@Nico04
Copy link

Nico04 commented Oct 23, 2020

No plans on fixing this ? I was planning to buy the product but this is a no-go for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to directly use git to calculate changes for diffs jackbentley/merge-request-integration
3 participants
@arturaz @jackbentley @Nico04