Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(signals): clarify that signal type can only be an object literal. #4327

Merged
merged 1 commit into from May 23, 2024
Merged

docs(signals): clarify that signal type can only be an object literal. #4327

merged 1 commit into from May 23, 2024

Conversation

rainerhahnekamp
Copy link
Contributor

Clarify that the state's type must be an object literal. See referenced issue below.

Closes #4316

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@netlify Netlify
Copy link

netlify bot commented May 12, 2024 •
edited

✅ Deploy Preview for ngrx-io ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8794352
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/6640d84e5ffeb30008257820
😎 Deploy Preview https://deploy-preview-4327--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

timdeschryver
timdeschryver approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@timdeschryver timdeschryver left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can't detect this with TS, do you think this can be useful as an eslint rule?
cc @markostanimirovic

@timdeschryver timdeschryver merged commit c15990a into ngrx:main May 23, 2024
5 checks passed
@rainerhahnekamp
Copy link
Contributor Author

@timdeschryver If you want to hear my opinion: an eslint rule would definitely make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonroberts brandonroberts brandonroberts approved these changes

@timdeschryver timdeschryver timdeschryver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

signalState changes passed array to map
3 participants
@rainerhahnekamp @brandonroberts @timdeschryver