-
-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email settings UI #293
Open
armisss4
wants to merge
24
commits into
ngoduykhanh:master
Choose a base branch
from
armisss4:email-settings-UI
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Email settings UI #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More than one user with Manager or Admin permissions can be created from UI
Patched some security holes with GetUser and UpdateUser, did some minor cleanup
Merge from development branch
Changed available actions done by an admin to itself: admin can no longer remove itself from users list, admin can no longer change its user type to manager.
User control patch
Added email settings page, settings now save in database, ability to send an email to client when it's created
Minor fixes
When downloading QR code, the filename will be Client name, instead of generic. Ability to left click on QR code to download it.
Qr code filename fix for downloading
Revert "Qr code filename fix for downloading"
Revert "User control patch"
Revert "Merge from development branch"
Email settings UI old
removed Admin: isAdmin(c) from baseData, as it doesnt exist in master
logikamente
approved these changes
Feb 10, 2023
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
would be nice if this is merged 👍 |
Yes, please merge this function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added email settings panel, where you can set SMTP or Sendgrid settings and change default email message.
Resolves #252, resolves #249, resolves #101