Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipv6 support for client configuration #223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

campbellbs
Copy link

IPv6 for client configuration is now possible with or without specific port. Different configurations were tested manually, e.g.:

tests

@stale
Copy link

stale bot commented Nov 22, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 22, 2022
@ngoduykhanh ngoduykhanh removed the stale label Dec 2, 2022
@campbellbs campbellbs mentioned this pull request Jan 7, 2023
@foux
Copy link

foux commented Jan 23, 2023

Any reason this can't be merged?
Thanks

@stale
Copy link

stale bot commented Mar 24, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 24, 2023
@systemcrash
Copy link
Contributor

I don't see the advantage to use an obscure library to verify an IPv6 address when one can simply use the net library and parse an address that way. It's more resilient and more widely used. Plus the various cases of the form "host:port", "host%zone:port", "[host]:port" or "[host%zone]:port" into host or host%zone and port don't all seem covered here.

There are also potentially cases when the IPv6::ffff:IPv4 forms may also arise.

@stale stale bot removed the stale label Mar 25, 2023
@Neustradamus
Copy link

@ngoduykhanh: What do you think?

@systemcrash
Copy link
Contributor

systemcrash commented Oct 9, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants