Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when using Target 2022 - Similar issue link provided #246

Open
AngularTx opened this issue Apr 9, 2024 · 9 comments
Open

Error when using Target 2022 - Similar issue link provided #246

AngularTx opened this issue Apr 9, 2024 · 9 comments

Comments

@AngularTx
Copy link

Hi There ,

I just migrated my angular codebase to 15 via NX . The application was running firn earlier without ant errors. Now after the migration we see some errors in console related to subscribe.

Also found the below issues reported that using UntilDestroy() causes the issue. I would like to know if this issue is really from or changing target to 2020 works fine with no errors in console.

angular/components#26335

@arturovt
Copy link
Collaborator

arturovt commented Apr 9, 2024

This issue will be closed soon if a reproducible example is not provided. There is no justification for making assertions based solely on text; without a concrete problem visible, we cannot address it effectively. Additionally, we will not be making any changes for Angular 15 because: 1) We are significantly ahead of this version, and 2) Its LTS support ends in one month.

@AngularTx
Copy link
Author

angular/components#26335
Here the details are given.

They closed the issue there stating that its due to UntilDestroyed . So I think we have a good example in that link.

@arturovt
Copy link
Collaborator

arturovt commented Apr 9, 2024

I am unclear about the specific issue and its relation to the material.

@AngularTx
Copy link
Author

AngularTx commented Apr 9, 2024

@UntilDestroy({ checkProperties: true })

when this is used , seems like we get the error in console.

when target is 2022 set for compiler option.

Option was to make it 2020, or get rid of this @UntilDestroy(). But doing that we are losing all of the functionality of ngneat here.

When we make it 2020, the code runs with no errors.

@arturovt
Copy link
Collaborator

arturovt commented Apr 9, 2024

Could you please provide a minimal reproducible example so that we can proceed with resolving the issue?

@AngularTx
Copy link
Author

AngularTx commented Apr 9, 2024

@arturovt
Copy link
Collaborator

arturovt commented Apr 9, 2024

However, this is Angular 10, and the library version is 7.3.2, which significantly lags behind in terms of all the fixes it has received since then. What are we expected to fix under these circumstances?

@AngularTx
Copy link
Author

What version is expected for angular 15 and above for ngneat ?

@arturovt
Copy link
Collaborator

arturovt commented Apr 9, 2024

@ngneat/[email protected] and above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants