Atomic keys introduction for strings, symbols, small numbers. #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VadimZhestikov
changed the title
|
The issue is obtained by check-pr, when dynamic modules are configured with quickjs-ng, for case when 'js_engine qjs;' is not used. I still trying reproduce it on my local pc, but those tests run w/o issues for me. Continuing. |
VadimZhestikov
force-pushed
the
atomic_strings_new
branch
13 times, most recently
from
269870d to
d0dc432
Compare
-- use njs_atom_atomize_key();
-- remove symbol_generator;
-- remove NJS_SYMBOL_KNOWN_MAX;
-- use atom_ids in njs_object_hash_test();
-- use atom_id as key_hash;
-- remove NJS_*_HASH;
-- remove not used files;
-- remove name_value except for atom_id from
njs_object_prop_s.
Performance (bench4.js) for reference:
before all atomic patches:
Richards: 386
Crypto: 933
Splay: 1752
NavierStokes: 1336
----
Score (version 7): 959
after this patch:
Richards: 541
Crypto: 931
Splay: 2039
NavierStokes: 1224
----
Score (version 7): 1059
Performance (bench4.js) for reference:
after this patch:
Richards: 561
Crypto: 1030
Splay: 2078
NavierStokes: 1225
----
Score (version 7): 1101
Performance (bench4.js) for reference:
after this patch:
Richards: 686
Crypto: 1028
Splay: 2023
NavierStokes: 1652
----
Score (version 7): 1239
VadimZhestikov
force-pushed
the
atomic_strings_new
branch
from
cc67468 to
dd33c04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is series of commits which introduce internal atomic representation for
strings, symbols and small numbers as keys for access object properties.
These commits are intended to speed up access to object properties.
Checklist
Before creating a PR, run through this checklist and mark each as complete:
CONTRIBUTINGdocument