Update Github Actions (#246)

Fix issues to the Github Actions tests so that they can be used for pr testing.

Author: ryanslatten

.github/workflows/build_test.arcgis.service.yaml

@@ -3,20 +3,19 @@ name: test and package arcgis service plugin
 on:
   workflow_dispatch:
   workflow_call:
-  push:
+  pull_request:
     paths:
       - .github/workflows/build_test.arcgis.service.yaml
       - .github/workflows/config.yaml
       - plugins/arcgis/service/**
 
 jobs:
-
   config:
     uses: ./.github/workflows/config.yaml
 
   test:
     name: test plugin arcgis.service
-    needs: [ config ]
+    needs: [config]
     runs-on: ubuntu-latest
     strategy:
       matrix:
@@ -31,15 +30,21 @@ jobs:
           cache: npm
           cache-dependency-path: |
             plugins/arcgis/service/package-lock.json
+      - name: build mage service
+        run: |
+          cd service
+          npm ci
+          npm run build
       - name: test with node ${{ matrix.node }}
         run: |
           cd plugins/arcgis/service
-          npm ci
+          npm ci --force
+          npm link ../../../service
           npm test
 
   package:
     name: package plugin arcgis.service
-    needs: [ config, test ]
+    needs: [config, test]
     runs-on: ubuntu-latest
     steps:
       - name: checkout
@@ -51,15 +56,21 @@ jobs:
           cache: npm
           cache-dependency-path: |
             plugins/arcgis/service/package-lock.json
-      - name: build
+      - name: build mage service
         run: |
-          cd plugins/arcgis/service
+          cd service
           npm ci
           npm run build
-      - name: pack
+      - name: build service for plugin
+        run: |
+          cd plugins/arcgis/service
+          npm ci --force
+          npm link ../../../service
+          npm run build
+      - name: package for plugin
         run: npm pack ./plugins/arcgis/service
       - name: upload package
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: arcgis.service-artifacts
           path: |

.github/workflows/build_test.arcgis.web-app.yaml

@@ -3,14 +3,13 @@ name: test and package arcgis web plugin
 on:
   workflow_dispatch:
   workflow_call:
-  push:
+  pull_request:
     paths:
       - .github/workflows/build_test.arcgis.web-app.yaml
       - .github/workflows/config.yaml
       - plugins/arcgis/web-app/**
 
 jobs:
-
   config:
     uses: ./.github/workflows/config.yaml
 
@@ -42,9 +41,8 @@ jobs:
         run: |
           npm pack ./plugins/arcgis/web-app/dist/main
       - name: upload packages
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: arcgis.web-app-artifacts
           path: |
             ngageoint-mage.arcgis.web-app-*.tgz
-

.github/workflows/build_test.image.service.yaml

@@ -3,20 +3,19 @@ name: test and package image service plugin
 on:
   workflow_dispatch:
   workflow_call:
-  push:
+  pull_request:
     paths:
       - .github/workflows/build_test.image.service.yaml
       - .github/workflows/config.yaml
       - plugins/image/service/**
 
 jobs:
-
   config:
     uses: ./.github/workflows/config.yaml
 
   test:
     name: test plugin image.service
-    needs: [ config ]
+    needs: [config]
     runs-on: ubuntu-latest
     strategy:
       matrix:
@@ -31,15 +30,22 @@ jobs:
           cache: npm
           cache-dependency-path: |
             plugins/image/service/package-lock.json
+      - name: build mage service
+        run: |
+          cd service
+          npm ci --force
+          npm run build
       - name: test with node ${{ matrix.node }}
         run: |
           cd plugins/image/service
-          npm ci
+          npm ci --force
+          npm install --os=linux --cpu=x64 sharp
+          npm link ../../../service
           npm test
 
   package:
     name: package plugin image.service
-    needs: [ config, test ]
+    needs: [config, test]
     runs-on: ubuntu-latest
     steps:
       - name: checkout
@@ -51,15 +57,22 @@ jobs:
           cache: npm
           cache-dependency-path: |
             plugins/image/service/package-lock.json
-      - name: build
+      - name: build mage service
         run: |
-          cd plugins/image/service
+          cd service
           npm ci
           npm run build
+      - name: build image service
+        run: |
+          cd plugins/image/service
+          npm ci --force
+          npm install --os=linux --cpu=x64 sharp
+          npm link ../../../service
+          npm run build
       - name: pack
         run: npm pack ./plugins/image/service
       - name: upload package
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: image.service-artifacts
           path: |

.github/workflows/build_test.nga-msi.yaml

@@ -3,20 +3,19 @@ name: test and package nga-msi plugin
 on:
   workflow_dispatch:
   workflow_call:
-  push:
+  pull_request:
     paths:
       - .github/workflows/build_test.nga-msi.yaml
       - .github/workflows/config.yaml
       - plugins/nga-msi/**
 
 jobs:
-
   config:
     uses: ./.github/workflows/config.yaml
 
   test:
     name: test plugin nga-msi
-    needs: [ config ]
+    needs: [config]
     runs-on: ubuntu-latest
     strategy:
       matrix:
@@ -31,15 +30,21 @@ jobs:
           cache: npm
           cache-dependency-path: |
             plugins/nga-msi/package-lock.json
+      - name: build mage service
+        run: |
+          cd service
+          npm ci
+          npm run build
       - name: test with node ${{ matrix.node }}
         run: |
           cd plugins/nga-msi
           npm ci
+          npm link ../../service
           npm test
 
   package:
     name: package plugin nga-msi
-    needs: [ config, test ]
+    needs: [config, test]
     runs-on: ubuntu-latest
     steps:
       - name: checkout
@@ -51,16 +56,22 @@ jobs:
           cache: npm
           cache-dependency-path: |
             plugins/nga-msi/package-lock.json
+      - name: build mage service
+        run: |
+          cd service
+          npm ci
+          npm run build
       - name: build
         run: |
           cd plugins/nga-msi
           npm ci
+          npm link ../../service
           npm run build
       - name: pack
         run: npm pack ./plugins/nga-msi
       - name: upload package
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: nga-msi-artifacts
           path: |
-            ngageoint-mage.*.tgz
+            ngageoint-mage.*.tgz

.github/workflows/build_test.service.yaml

@@ -3,7 +3,7 @@ name: build and test service
 on:
   workflow_dispatch:
   workflow_call:
-  push:
+  pull_request:
     paths:
       - .github/workflows/build_test.service.yaml
       - .github/workflows/config.yaml
@@ -15,7 +15,7 @@ jobs:
   build:
     name: build mage service
     needs: config
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - name: install system libs
         run: |
@@ -32,20 +32,23 @@ jobs:
         run: |
           cd service
           npm ci
-          npm run build
+      - name: run tests
+        run: |
+          cd service
+          npm test
       - name: package
         run: npm pack ./service
       - name: upload package
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: mage.service-artifacts
           path: |
             ngageoint-mage.service-*.tgz
 
   test:
     name: test mage service
-    needs: [ config, build ]
-    runs-on: ubuntu-latest
+    needs: [config, build]
+    runs-on: ubuntu-22.04
     strategy:
       matrix:
         node: ${{ fromJSON(needs.config.outputs.node_versions-all-json) }}
@@ -62,9 +65,9 @@ jobs:
       - name: install service dependencies
         run: |
           cd service
-          npm ci service
+          npm ci
       - name: download service package
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: mage.service-artifacts
       - name: extract service lib
@@ -76,4 +79,4 @@ jobs:
         run: |
           cd service
           npm run ci:test
-      # TODO: restore coveralls test coverage report - see buildAndTest.yml
+      # TODO: restore coveralls test coverage report - see buildAndTest.yml

.github/workflows/build_test.web-app.yaml

@@ -3,7 +3,7 @@ name: build and test web-app
 on:
   workflow_dispatch:
   workflow_call:
-  push:
+  pull_request:
     paths:
       - .github/workflows/build_test.web-app.yaml
       - .github/workflows/config.yaml
@@ -41,8 +41,8 @@ jobs:
           npm pack ./web-app/dist/core-lib
           npm pack ./web-app/dist
       - name: upload packages
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: mage.web-app-artifacts
           path: |
-            ngageoint-mage.*.tgz
+            ngageoint-mage.*.tgz

.github/workflows/release.arcgis_plugin.yaml

@@ -17,12 +17,11 @@ on:
   # release:
 
 jobs:
-
   config:
     uses: ./.github/workflows/config.yaml
 
   check_release_version:
-    needs: [ config ]
+    needs: [config]
     runs-on: ubuntu-latest
     steps:
       - name: checkout
@@ -41,16 +40,16 @@ jobs:
           [[ $(json version < ./plugins/arcgis/web-app/package.json) = ${{ inputs.version }} ]] || exit 1
 
   build_and_test-service:
-    needs: [ check_release_version ]
+    needs: [check_release_version]
     uses: ./.github/workflows/build_test.arcgis.service.yaml
 
   build_and_test-web-app:
-    needs: [ check_release_version ]
+    needs: [check_release_version]
     uses: ./.github/workflows/build_test.arcgis.web-app.yaml
 
   publish_packages:
-    name:  publish packages
-    needs: [ config, build_and_test-service ]
+    name: publish packages
+    needs: [config, build_and_test-service]
     runs-on: ubuntu-latest
     steps:
       - name: setup node
@@ -60,11 +59,11 @@ jobs:
       - name: install json util
         run: npm i -g json
       - name: download service packages
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: arcgis.service-artifacts
       - name: download web-app packages
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: arcgis.web-app-artifacts
       - name: publish to package registry