-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deep comparing props in shouldComponentUpdate (usage with preact-compat) #287
Comments
This affects React-Static users who opt for preact. What's the game plan here? |
I'm using react 16.3.* (without preact) and I have the problem.. One of the props in shouldComponentUpdate is object of FiberNode, and this object has recursive link to himself ( |
react-fast-compare just added support for Preact in [email protected]. Maybe this could be resolved by upgrading the dependency? |
Hey there,
I don't know if usage with
preact-compat
is something this lib intends to support, so I'll just ask. =)I opened this issue there: preactjs/preact-compat#391
Is this something that could be fixed in
react-helmet
? Or should I just replace it withpreact-helmet
?Thanks in advance!
The text was updated successfully, but these errors were encountered: