Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nf-test to explicitly check detection of PacBio adapters #5698

Merged
merged 1 commit into from
May 27, 2024

Conversation

GallVp
Copy link
Member

@GallVp GallVp commented May 27, 2024

PR checklist

Closes #XXX

  • Added nf-test to explicitly check detection of PacBio adapters
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@GallVp GallVp requested a review from d4straub as a code owner May 27, 2024 00:17
@GallVp GallVp requested review from SPPearce and muffato May 27, 2024 00:18
Copy link
Contributor

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But I do not have too much of experience with nf-test.

@GallVp GallVp added this pull request to the merge queue May 27, 2024
Merged via the queue into nf-core:master with commit f0732b3 May 27, 2024
11 checks passed
@GallVp GallVp deleted the fcs/fcsadaptor branch May 27, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants