Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Sambamba to 1.0.1 #5695

Merged
merged 4 commits into from
May 27, 2024
Merged

Bump Sambamba to 1.0.1 #5695

merged 4 commits into from
May 27, 2024

Conversation

scwatts
Copy link
Contributor

@scwatts scwatts commented May 26, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@scwatts
Copy link
Contributor Author

scwatts commented May 27, 2024

Somewhat cryptic error:

Command error:
  INFO:    Environment variable SINGULARITYENV_TMPDIR is set, but APPTAINERENV_TMPDIR is preferred
  INFO:    Environment variable SINGULARITYENV_NXF_TASK_WORKDIR is set, but APPTAINERENV_NXF_TASK_WORKDIR is preferred
  
  sambamba 1.0.1
   by Artem Tarasov and Pjotr Prins (C) 2012-2023
      LDC 1.28.1 / DMD v2.098.1 / LLVM12.0.0 / bootstrap LDC - the LLVM D compiler (1.28.1)
  
  sambamba-markdup: /home/ubuntu/sambamba-pid16-markdup-srjw: Read-only file system

Trying to resolve by explicitly setting a temporary directory for Sambamba. I expect that changes to the command also result in a different checksum of the BAM, which will need to be updated if so.

@scwatts scwatts added this pull request to the merge queue May 27, 2024
Merged via the queue into nf-core:master with commit 33b3ce8 May 27, 2024
24 checks passed
@scwatts scwatts deleted the bump-sambamba branch May 27, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants