Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom objects #1338

Closed
edmundmiller opened this issue Feb 22, 2022 · 5 comments
Closed

Use custom objects #1338

edmundmiller opened this issue Feb 22, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request stale Stale

Comments

@edmundmiller
Copy link
Contributor

Making an issue for tracking, hopefully I'll get some time to work on a PoC soon.

@drpatelh @mahesh-panchal @heuermh @nh13

@edmundmiller edmundmiller added the enhancement New feature or request label Feb 22, 2022
@edmundmiller edmundmiller self-assigned this Feb 22, 2022
@edmundmiller
Copy link
Contributor Author

During nf-core modules install it should check for a lib/customobjects.groovy, and if it doesn't match the updated one, it should install it.

The lib/customobject.groovy will be added to the nf-core template, but checking for the file with nf-core modules install will allow non-nf-core pipelines to still use nf-core modules.

Thanks, @JoseEspinosa, for working with me on the idea!

@JoseEspinosa
Copy link
Member

😄 That will be really cool stuff!

@nh13
Copy link
Member

nh13 commented Mar 16, 2022

if it doesn't match the updated one, it should install it.

what does this mean?

@edmundmiller
Copy link
Contributor Author

what does this mean?

Sorry, I see the alarm, it should add the file on the first nf-core modules install, just like modules.json. On subsequent nf-modules installs we'll add on a check to make sure the user hasn't updated the lib/customobjects.groovy(Probably call it nf-core-customobjects to keep it clear) and throw a warning that here be dragons if they choose to modify it themselves.

@jasmezz
Copy link
Contributor

jasmezz commented Mar 7, 2023

Hi there!

We’ve noticed there hasn’t been much activity here. Are you still planning on working on this?
If not, you can ignore this message and we’ll close your PR/issue in about 2 weeks.
If you think this is still relevant, you can also add it to the hackathon2023 project board.

Cheers
the nf-core maintainers

@jasmezz jasmezz added the stale Stale label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale Stale
Projects
None yet
Development

No branches or pull requests

5 participants