Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of --mergeContext for MethylDackel #460

Open
dcarrillox opened this issue Nov 21, 2024 · 5 comments · May be fixed by #499
Open

Addition of --mergeContext for MethylDackel #460

dcarrillox opened this issue Nov 21, 2024 · 5 comments · May be fixed by #499
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dcarrillox
Copy link

Description of feature

Hi,

Have you considered adding the --mergeContext option for the bwameth + MethylDackel workflow? It collapses methylation calls at Cytosine level to CpG site level, and the same goes for the CHG and CHH contexts if --comprehensive is used.

I think it could be a very interesting addition which also would simplify downstream analysis.

Thanks,
Daniel

@dcarrillox dcarrillox added the enhancement New feature or request label Nov 21, 2024
@sateeshperi
Copy link
Contributor

hi @dcarrillox sounds like a good idea! Do you have any docs reference for the --mergeContext option ?

@dcarrillox
Copy link
Author

Hi @sateeshperi, yes! This feature is explained in the Per-CpG/CHG metrics section of the MethylDackel README

@sateeshperi
Copy link
Contributor

the bwameth subworkflow would soon be available as standalone in nf=core/modules repo.
PR here

Would you be interested in contributing to this feature ?

@dcarrillox
Copy link
Author

Hi @sateeshperi, yes I can try. Any particular aspect you think I could start with?

@sateeshperi sateeshperi added this to the 3.1.0 milestone Dec 17, 2024
@sateeshperi sateeshperi self-assigned this Dec 17, 2024
@sateeshperi sateeshperi linked a pull request Dec 17, 2024 that will close this issue
@sateeshperi
Copy link
Contributor

hi @dcarrillox could you take a look at the branch that is linked to this issue and if you could verify that the bed graphs now indeed produce merged contexts when running with comprehensive ? that would be gr8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants