Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(calendar): scrolling is hidden when changing the month #2949

Open
wants to merge 2 commits into
base: canary
Choose a base branch
from
Open

fix(calendar): scrolling is hidden when changing the month #2949

wants to merge 2 commits into from

Conversation

novsource
Copy link
Contributor

@novsource novsource commented May 4, 2024 •
edited by coderabbitai bot

Closes #2945

📝 Description

Removed scrolling display during month change animation

⛳️ Current behavior (updates)

Before.mp4

🚀 New behavior

After.mp4

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

Summary by CodeRabbit

  • Bug Fixes
    • Improved the calendar display by removing the scrolling during month change animations.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 4, 2024 •
edited

🦋 Changeset detected

Latest commit: 9c03274

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@nextui-org/theme Patch
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented May 4, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 1:48pm

@vercel Vercel
Copy link

vercel bot commented May 4, 2024

Someone is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 4, 2024 •
edited

Walkthrough

The changes aim to resolve a user interface bug in the @nextui-org/calendar module by adjusting the calendar.ts file to include an overflow-hidden property in the headerWrapper style. This modification is intended to address the issue of a horizontal scrollbar appearing during month changes in the calendar component.

Changes

File Path Change Summary
.../theme/src/components/calendar.ts Added overflow-hidden to headerWrapper style.

Assessment against linked issues

Objective Addressed Explanation
Prevent scrollbar display during month switch (#2945) ✅
Ensure visual consistency during transitions (#2945) ❓ It's unclear if the change fully maintains visual consistency during transitions without further context or testing results.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits Files that changed from the base of the PR and between 8c7c359 and 9c03274.
Files selected for processing (1)
  • .changeset/tough-carpets-marry.md (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .changeset/tough-carpets-marry.md

@wingkwong wingkwong added this to the v2.3.7 milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai left review comments

@wingkwong wingkwong wingkwong approved these changes

@jrgarciadev jrgarciadev Awaiting requested review from jrgarciadev jrgarciadev is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@jrgarciadev jrgarciadev

Labels
None yet
Projects
None yet
Milestone
v2.3.7
Development

Successfully merging this pull request may close these issues.

[BUG] - Calendar overflow-x
3 participants
@novsource @wingkwong @jrgarciadev