Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long footnotes can overlap code listings #564

Open
hlship opened this issue Oct 19, 2023 · 4 comments · Fixed by #573
Open

Long footnotes can overlap code listings #564

hlship opened this issue Oct 19, 2023 · 4 comments · Fixed by #573
Assignees
@philippamarkovics

Comments

@hlship
Copy link

hlship commented Oct 19, 2023

image

I believe there needs to be a clear:both CSS attribute in the mix somewhere, so that the listing moves down below the footnote.
@philippamarkovics philippamarkovics mentioned this issue Nov 9, 2023
Merged
@mk mk closed this as completed in #573 Nov 9, 2023
mk pushed a commit that referenced this issue Nov 9, 2023
@philippamarkovics
Fix overlapping sidenotes (#573)
8b804e7 
Sidenotes that are longer than the content they are anchored to will now push their subsequent content down instead of overlapping with it.

Note: This uses `display: flex` now instead of positioning the sidenotes absolutely, thus preventing margin collapse with subsequent nodes that don’t have sidenotes. The layout adjusts for this now.

Closes #564.
@philippamarkovics
Copy link
Member

@hlship The issue should be fixed now and thanks for your patience! Can you confirm?

@hlship
Copy link
Author

hlship commented Nov 9, 2023

I should have a chance to check it out tomorrow.

@hlship
Copy link
Author

hlship commented Nov 10, 2023

image Looks much better, thanks!

@mk
Copy link
Member

mk commented Nov 11, 2023

It's better but not quite good, yet. @philippamarkovics can we make sure the sidenote only pushes :wide or :full-width content down but not :prose like the paragraph?

@mk mk reopened this Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philippamarkovics philippamarkovics

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix overlapping sidenotes nextjournal/clerk
3 participants
@mk @philippamarkovics @hlship