Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX on 2FA select challenge page is broken #335

Open
heapifyman opened this issue Jan 22, 2023 · 3 comments
Open

UX on 2FA select challenge page is broken #335

heapifyman opened this issue Jan 22, 2023 · 3 comments
Assignees
Labels
2. developing Work in progress bug Something isn't working design Related to design, interface, interaction design, UX, etc.

Comments

@heapifyman
Copy link

Steps to reproduce

  1. Setup 2FA with both Authenticator App and a security key (for example SoloKey)
  2. Login

Expected behaviour

The page after the login form /login/selectchallenge should be usable with keyboard.

The "buttons" to select the 2FA method (either Authenticator App or Security Key) should be highlighted when using Tab key to switch focus between elements on the page.

The buttons (form) should have a visual appearance that is consistent with the rest of the default nextcloud style.

Actual behaviour

The "buttons" to select the 2FA method (either Authenticator App or Security Key) are not highlighted when using Tab key to switch focus between elements on the page.

It is impossible to know which button (method) is currently selected.

This was working in nextcloud 24.

The buttons look terrible, don't follow the default nextcloud style for buttons - see
swappy-20230122_120616

Server configuration

Operating system:

Web server:

Database:

PHP version:

Version: (see admin page)

Updated from an older version or fresh install: updated from 24

List of activated apps:

If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your server installation folder

The content of config/config.php:

If you have access to your command line run e.g.:
sudo -u www-data php occ config:list system
from within your Nextcloud installation folder

or

Insert your config.php content here
Make sure to remove all sensitive content such as passwords. (e.g. database password, passwordsalt, secret, smtp password, …)

Client configuration

Browser: Firefox and Brave

Operating system: Manjaro Linux

Logs

Web server error log
Insert your webserver log here
Server log (data/nextcloud.log)
Insert your server log here
Browser log
Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log
@st3iny
Copy link
Member

st3iny commented Nov 13, 2023

This has been fixed in the meantime.

@st3iny st3iny closed this as completed Nov 13, 2023
@heapifyman
Copy link
Author

@st3iny in which version has this been fixed? I tried with Two-Factor WebAuthn 1.3.0 on nextcloud 27.1.3, and it is still not possible to determine if TOTP or Security Key is active when tabbing through the dialog.

@st3iny
Copy link
Member

st3iny commented Nov 16, 2023

You're right, the tabbing is not fixed yet. I'm sorry for closing the ticket early.

@st3iny st3iny reopened this Nov 16, 2023
@st3iny st3iny added bug Something isn't working 2. developing Work in progress design Related to design, interface, interaction design, UX, etc. labels Nov 28, 2023
@st3iny st3iny self-assigned this Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress bug Something isn't working design Related to design, interface, interaction design, UX, etc.
Projects
None yet
Development

No branches or pull requests

2 participants