Merge pull request #48856 from nextcloud/backport/48839/stable30

nickvergessen · web-flow · commit 2f7837e73c53 · 2024-10-24T21:16:29.000+02:00
[stable30] build: Print RTL limited characters in translation-checker
diff --git a/build/translation-checker.php b/build/translation-checker.php
@@ -77,8 +77,8 @@
 		$content = file_get_contents($file->getPathname());
 
 		$language = pathinfo($file->getFilename(), PATHINFO_FILENAME);
-		if (!in_array($language, $rtlLanguages, true) && preg_match('/[' . implode('', $rtlCharacters) . ']/u', $content)) {
-			$errors[] = $file->getPathname() . "\n" . '  ' . 'Contains a RTL limited character in the translations.' . "\n";
+		if (!in_array($language, $rtlLanguages, true) && preg_match_all('/^(.+[' . implode('', $rtlCharacters) . '].+)$/mu', $content, $matches)) {
+			$errors[] = $file->getPathname() . "\n" . '  ' . 'Contains a RTL limited characters in the translations. Offending strings:' . "\n" . implode("\n", $matches[0]) . "\n";
 		}
 
 		$json = json_decode($content, true);

Original file line number	Diff line number	Diff line change
`@@ -77,8 +77,8 @@`
`77`	`77`	`$content = file_get_contents($file->getPathname());`
`78`	`78`
`79`	`79`	`$language = pathinfo($file->getFilename(), PATHINFO_FILENAME);`
`80`		`- if (!in_array($language, $rtlLanguages, true) && preg_match('/[' . implode('', $rtlCharacters) . ']/u', $content)) {`
`81`		`- $errors[] = $file->getPathname() . "\n" . ' ' . 'Contains a RTL limited character in the translations.' . "\n";`
	`80`	`+ if (!in_array($language, $rtlLanguages, true) && preg_match_all('/^(.+[' . implode('', $rtlCharacters) . '].+)$/mu', $content, $matches)) {`
	`81`	`+ $errors[] = $file->getPathname() . "\n" . ' ' . 'Contains a RTL limited characters in the translations. Offending strings:' . "\n" . implode("\n", $matches[0]) . "\n";`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`$json = json_decode($content, true);`