From 8d60dd8c8f5be87491a8823aa5b03f6c86b2a506 Mon Sep 17 00:00:00 2001
From: Joas Schilling <coding@schilljs.com>
Date: Thu, 7 Dec 2023 13:15:13 +0100
Subject: [PATCH] Commit problem before lunch

---
 tests/appinfo/routes.php                    |  1 +
 tests/lib/Controller/SettingsController.php | 15 ++++
 tests/openapi.json                          | 76 +++++++++++++++++++++
 3 files changed, 92 insertions(+)

diff --git a/tests/appinfo/routes.php b/tests/appinfo/routes.php
index 13dd501..5b32560 100644
--- a/tests/appinfo/routes.php
+++ b/tests/appinfo/routes.php
@@ -32,6 +32,7 @@
 		['name' => 'Settings#adminScope', 'url' => '/api/{apiVersion}/admin', 'verb' => 'POST', 'requirements' => ['apiVersion' => '(v2)']],
 		['name' => 'Settings#doubleScope', 'url' => '/api/{apiVersion}/double', 'verb' => 'POST', 'requirements' => ['apiVersion' => '(v2)']],
 		['name' => 'Settings#throwing', 'url' => '/api/{apiVersion}/throwing', 'verb' => 'POST', 'requirements' => ['apiVersion' => '(v2)']],
+		['name' => 'Settings#nestedSchemas', 'url' => '/api/{apiVersion}/nested-schemas', 'verb' => 'POST', 'requirements' => ['apiVersion' => '(v2)']],
 
 		['name' => 'Settings2#defaultAdminScopeOverwritten', 'url' => '/api/{apiVersion}/default-admin-overwritten', 'verb' => 'POST', 'requirements' => ['apiVersion' => '(v2)']],
 		['name' => 'Settings2#defaultAdminScope', 'url' => '/api/{apiVersion}/default-admin', 'verb' => 'POST', 'requirements' => ['apiVersion' => '(v2)']],
diff --git a/tests/lib/Controller/SettingsController.php b/tests/lib/Controller/SettingsController.php
index d7f7084..c1c19a9 100644
--- a/tests/lib/Controller/SettingsController.php
+++ b/tests/lib/Controller/SettingsController.php
@@ -35,6 +35,7 @@
 
 /**
  * @psalm-import-type NotificationsPushDevice from ResponseDefinitions
+ * @psalm-import-type NotificationsNotification from ResponseDefinitions
  */
 #[OpenAPI(scope: OpenAPI::SCOPE_FEDERATION)]
 class SettingsController extends OCSController {
@@ -134,4 +135,18 @@ public function doubleScope(): DataResponse {
 	public function throwing(): DataResponse {
 		throw new OCSNotFoundException();
 	}
+
+	/**
+	 * @NoAdminRequired
+	 *
+	 * Route is ignored because of scope on the controller
+	 *
+	 * @return DataResponse<Http::STATUS_OK, list<NotificationsNotification>, array{}>
+	 *
+	 * 200: OK
+	 */
+	#[OpenAPI]
+	public function nestedSchemas(): DataResponse {
+		return new DataResponse();
+	}
 }
diff --git a/tests/openapi.json b/tests/openapi.json
index 4eb5bb0..9c936e6 100644
--- a/tests/openapi.json
+++ b/tests/openapi.json
@@ -189,6 +189,82 @@
                 }
             }
         },
+        "/ocs/v2.php/apps/notifications/api/{apiVersion}/nested-schemas": {
+            "post": {
+                "operationId": "settings-nested-schemas",
+                "summary": "Route is ignored because of scope on the controller",
+                "tags": [
+                    "settings"
+                ],
+                "security": [
+                    {
+                        "bearer_auth": []
+                    },
+                    {
+                        "basic_auth": []
+                    }
+                ],
+                "parameters": [
+                    {
+                        "name": "apiVersion",
+                        "in": "path",
+                        "required": true,
+                        "schema": {
+                            "type": "string",
+                            "enum": [
+                                "v2"
+                            ],
+                            "default": "v2"
+                        }
+                    },
+                    {
+                        "name": "OCS-APIRequest",
+                        "in": "header",
+                        "description": "Required to be true for the API request to pass",
+                        "required": true,
+                        "schema": {
+                            "type": "boolean",
+                            "default": true
+                        }
+                    }
+                ],
+                "responses": {
+                    "200": {
+                        "description": "OK",
+                        "content": {
+                            "application/json": {
+                                "schema": {
+                                    "type": "object",
+                                    "required": [
+                                        "ocs"
+                                    ],
+                                    "properties": {
+                                        "ocs": {
+                                            "type": "object",
+                                            "required": [
+                                                "meta",
+                                                "data"
+                                            ],
+                                            "properties": {
+                                                "meta": {
+                                                    "$ref": "#/components/schemas/OCSMeta"
+                                                },
+                                                "data": {
+                                                    "type": "array",
+                                                    "items": {
+                                                        "$ref": "#/components/schemas/Notification"
+                                                    }
+                                                }
+                                            }
+                                        }
+                                    }
+                                }
+                            }
+                        }
+                    }
+                }
+            }
+        },
         "/ocs/v2.php/apps/notifications/api/{apiVersion}/default-admin-overwritten": {
             "post": {
                 "operationId": "settings2-default-admin-scope-overwritten",