Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMB #2145

Open
7 tasks
joshtrichards opened this issue Jan 12, 2024 · 2 comments
Open
7 tasks

SMB #2145

joshtrichards opened this issue Jan 12, 2024 · 2 comments
Labels

Comments

@joshtrichards
Copy link
Member

joshtrichards commented Jan 12, 2024

Documentation

There are inconsistencies between the SMB and FULL examples examples:

The former appears to be out-dated while the latter appears to better match the PHP image's recommended approach.

Some problems have been reported by others trying to use the SMB examples - e.g.

Tasks (preliminary):

  • Review PHP image's recommended approach for adding things
  • Assess whether our FULL example follows the PHP image model and otherwise seems reasonable
  • Confirm native rather than wrapped SMB mode is detected/used by External Storage
  • Test FULL example against a "typical" SMB server
  • Port tested FULL example to SMB only example

Out of scope but worth mentioning:

  • Upstream docs in this area could probably use some clarity (and I don't mean specific to Docker)

Image

Worth a revisit of whether to include/why we're not including smbclient in the image by default

Context:

Tasks

  • ... TBD
  • If not including, document why as a FAQ/Known Issue in the README
@joshtrichards joshtrichards changed the title SMB examples SMB Jan 16, 2024
@joshtrichards
Copy link
Member Author

We also might want to explore documenting some other ways of mounting CIFS/SMB volumes since people don't seem to be aware of them:

  • fstab (OS)
  • docker volumes with the cifs driver (OS+docker)
  • etc

Though at some point this is outside the scope of the image and more a pure documentation issue - and it's not realistic for us to document all third-party integrations. But maybe some hints + links to third-party docs

@juan11perez
Copy link

Gents,
I used the first example and worked fine for me.
I'm moving away from AIO and it did have smb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants