Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

NYT CSS + dependencies #10

Open
lfbrandao opened this issue Jun 19, 2017 · 3 comments
Open

NYT CSS + dependencies #10

lfbrandao opened this issue Jun 19, 2017 · 3 comments

Comments

@lfbrandao
Copy link

Hi @jeremybmerrill!

The templates are loading NYT stylesheets and templates. Have you considered getting these under source control? And document what they do? Here's what I found:

https://github.com/newsdev/foialawya/blob/master/foias/templates/base.html#L6
https://github.com/newsdev/foialawya/blob/master/foias/templates/base.html#L65
https://github.com/newsdev/foialawya/blob/master/foias/templates/admin/base.html#L9

There's also a mention to the NYT here:
https://github.com/newsdev/foialawya/blob/master/foias/views.py#L25

that I haven't tested yet, but believe will be displayed on "social" login error

@jeremybmerrill
Copy link
Contributor

Hi @lfbrandao: Thanks for taking a look!

Those stylesheets are all from an NYT library that offers administrative components; a slightly more full-featured version of https://github.com/newsdev/adcom, that I didn't have time to factor out. I don't remember exactly what it does, maybe it can be factored out easily... I'll take a look.

I'll figure out how to get that @nytimes.com mention out of there. I was gonna work a little on this app today or tomorrow, so I can probably do that too.

@lfbrandao
Copy link
Author

Wonderful, thank you! Not super urgent, but figured it was worth mentioning

@jeremybmerrill
Copy link
Contributor

fixed teh second issue here: 8b95ede

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants