test: Added tests

Author: cade-conklin

v3/integrations/nroci/example/main.go

@@ -19,7 +19,7 @@ func main() {
 	if err != nil {
 		panic(err)
 	}
-	app.WaitForConnection(10 * time.Second)
+	app.WaitForConnection(10 * time.Second) // for short lived processes in apps
 	defer app.Shutdown(10 * time.Second)
 
 	cfg := nroci.NRDefaultConfig()

v3/integrations/nroci/nroci_nosql_test.go

@@ -116,16 +116,16 @@ func extractHostPort(endpoint string) (host, port string) {
 }
 
 func extractRequestFields(req any) (string, string, string) {
-	var collection, statement, databaseName string
+	var collection, statement, namespace string
 	switch r := req.(type) {
 	case *nosqldb.TableRequest:
 		collection = r.TableName
 		statement = r.Statement
-		databaseName = r.Namespace
+		namespace = r.Namespace
 	default:
 		// keep strings empty
 	}
-	return collection, statement, databaseName
+	return collection, statement, namespace
 }
 
 // executeWithDatastoreSegment is a generic helper function that executes a query with a given function from the
@@ -146,12 +146,12 @@ func executeWithDatastoreSegment[T any, R any](
 
 	// Extract host and port from config endpoint
 	host, port := extractHostPort(cw.Config.Endpoint)
-	collection, statement, databaseName := extractRequestFields(rw.ClientRequest)
+	collection, statement, namespace := extractRequestFields(rw.ClientRequest)
 	sgmt := newrelic.DatastoreSegment{
 		StartTime:          txn.StartSegmentNow(),
 		Product:            newrelic.DatastoreOracle,
 		Collection:         collection,
-		DatabaseName:       databaseName,
+		DatabaseName:       namespace, // using the namespace as the database name in this instance
 		ParameterizedQuery: statement,
 		Host:               host,
 		PortPathOrID:       port,

v3/integrations/nroci/nroci_nosql.go renamed to v3/integrations/nroci/nrocinosql.go

@@ -0,0 +1,125 @@
+// Copyright 2020 New Relic Corporation. All rights reserved.
+// SPDX-License-Identifier: Apache-2.0
+package nroci
+
+import (
+	"testing"
+
+	"github.com/oracle/nosql-go-sdk/nosqldb"
+)
+
+func Test_extractRequestFields(t *testing.T) {
+	// as we move into other types of requests, I will refactor this test to take in those types as well
+	tests := []struct {
+		name string // description of this test case
+		// Named input parameters for target function.
+		req   any
+		want  string
+		want2 string
+		want3 string
+	}{
+		{
+			name:  "Default case should return 3 empty strings with non-used type",
+			req:   &nosqldb.SystemRequest{},
+			want:  "",
+			want2: "",
+			want3: "",
+		},
+		{
+			name: "Should populate all 3 strings with *nosqldb.TableRequest",
+			req: &nosqldb.TableRequest{
+				TableName: "table1",
+				Statement: `SELECT * FROM table1 WHERE param="value"`,
+				Namespace: "oci_test",
+			},
+			want:  "table1",
+			want2: `SELECT * FROM table1 WHERE param="value"`,
+			want3: "oci_test",
+		},
+		{
+			name:  "Should return empty string with *nosqldb.TableRequest",
+			req:   &nosqldb.TableRequest{},
+			want:  "",
+			want2: "",
+			want3: "",
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got, got2, got3 := extractRequestFields(tt.req)
+			if got != tt.want {
+				t.Errorf("extractRequestFields() = %v, want %v", got, tt.want)
+			}
+			if got2 != tt.want2 {
+				t.Errorf("extractRequestFields() = %v, want %v", got2, tt.want2)
+			}
+			if got3 != tt.want3 {
+				t.Errorf("extractRequestFields() = %v, want %v", got3, tt.want3)
+			}
+		})
+	}
+}
+
+func Test_extractHostPort(t *testing.T) {
+	tests := []struct {
+		name string // description of this test case
+		// Named input parameters for target function.
+		endpoint string
+		want     string
+		want2    string
+	}{
+		{
+			name:     "Endpoint is empty should return 2 empty strings",
+			endpoint: "",
+			want:     "",
+			want2:    "",
+		},
+		{
+			name:     "url.Parse returns an error.  Should return 2 empty strings",
+			endpoint: "not:an.en#d()point",
+			want:     "",
+			want2:    "",
+		},
+		{
+			name:     "Host and port both exist in a valid url with https scheme",
+			endpoint: "https://ocitest:8080",
+			want:     "ocitest",
+			want2:    "8080",
+		},
+		{
+			name:     "Host and port both exist in a valid url with http scheme",
+			endpoint: "http://ocitest:8080",
+			want:     "ocitest",
+			want2:    "8080",
+		},
+		{
+			name:     "Host exists but port does not in a valid url with https scheme",
+			endpoint: "https://ocitest",
+			want:     "ocitest",
+			want2:    "443",
+		},
+		{
+			name:     "Host exists but port does not in a valid url with http scheme",
+			endpoint: "http://ocitest",
+			want:     "ocitest",
+			want2:    "80",
+		},
+		{
+			name:     "Host exists and pot exist but no scheme provided",
+			endpoint: "ocitest",
+			want:     "ocitest",
+			want2:    "80",
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got, got2 := extractHostPort(tt.endpoint)
+			if got != tt.want {
+				t.Errorf("extractHostPort() -> host = %v, want %v", got, tt.want)
+			}
+			if got2 != tt.want2 {
+				t.Errorf("extractHostPort() -> port = %v, want %v", got2, tt.want2)
+			}
+		})
+	}
+}