Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Add embedded-nal implementation #14

Open
MathiasKoch opened this issue Feb 26, 2021 · 13 comments
Open

[Suggestion] Add embedded-nal implementation #14

MathiasKoch opened this issue Feb 26, 2021 · 13 comments

Comments

@MathiasKoch
Copy link

Hi,

This crate looks awesome!

Just in case you did not know it existed, i wanted to share https://github.com/rust-embedded-community/embedded-nal/ as i think it could benefit the adoption of this crate over all, as it makes it drop-in replaceable with all the other crates/devices requiring embedded-nal

@newAM
Copy link
Owner

newAM commented Feb 26, 2021

My biggest concern with that is maintenance of the no-std-net dependency, it appears to be maintained by just @dunmatt.

I really like that the embedded-nal is under a project with multiple owners, allowing it to live on beyond any one maintainer.

Do you think we could move no-std-net under the embedded-community banner as well (@dunmatt)?

There are some optional features in the networking types here that I would be interested in adding to that as well:

...on a related topic, is there an RFC process for adding a crate to the rust embedded community?
I would really like add a standalone no_std EUI-48 and EUI-64 crate somewhere.

@dunmatt
Copy link

dunmatt commented Feb 26, 2021 via email

@newAM
Copy link
Owner

newAM commented Feb 27, 2021

@eldruin would you be able to give @dunmatt a no-std-net repository in the rust embedded community, to complement the embedded-nal? Not sure if there is an RFC process or anything more formal that needs to be done here.

(Sorry if I got the wrong person, it looks like @eldruin has access to make new repos on the rust-embedded community.)

@eldruin
Copy link

eldruin commented Feb 28, 2021

I would agree to that. There are two ways to proceed:

  1. I think what would make most sense would be for @dunmatt to join the r-e-c org and transfer the repository.
  2. We create a fork inside the r-e-c and give @dunnmatt rights on that fork.

@dunmatt If you are interested in this, please open an issue in the meta repository.

Please note that the r-e-c will soon be renamed rust-embedded-unofficial once I find some time, in case the name is relevant for your decision.

@dunmatt
Copy link

dunmatt commented Mar 20, 2021 via email

@andresv
Copy link

andresv commented Nov 6, 2021

It has been quiet, I guess concern with no-std-net is not yet solved?

@dunmatt
Copy link

dunmatt commented Nov 6, 2021 via email

@dunmatt
Copy link

dunmatt commented Nov 7, 2021

Alrighty, sorry for dropping the ball on that, should be taken care of rust-embedded-community/meta#14

@MathiasKoch
Copy link
Author

Guess this died out again? @eldruin @dunmatt

@eldruin
Copy link

eldruin commented Dec 22, 2021

Alright, I have invited @dunmatt now to the r-e-c org.
Once you accept, you can transfer the repository.
Thanks for the heads up @MathiasKoch.

@elpiel
Copy link

elpiel commented Feb 6, 2023

Any update on moving no-std-net to r-e-c?

@newAM
Copy link
Owner

newAM commented Feb 6, 2023

The RFC for networking types in core got merged, looks like it won't take much longer for implementation.

@newAM
Copy link
Owner

newAM commented Apr 22, 2023

Small update on this, the ip_in_core feature is available on nightly, and I added support for it in #245.

I opened a PR to add ip_in_core support to embedded-nal: rust-embedded-community/embedded-nal#81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants