Skip to content

Commit f24bf10

Browse files
authored
switch mantid to mantidworkbench (#12)
* switch mantid to mantidworkbench Signed-off-by: Jose Borreguero <[email protected]> * updated pull request template Signed-off-by: Jose Borreguero <[email protected]> * add release notes Signed-off-by: Jose Borreguero <[email protected]> --------- Signed-off-by: Jose Borreguero <[email protected]>
1 parent 6fcf4b8 commit f24bf10

File tree

3 files changed

+31
-13
lines changed

3 files changed

+31
-13
lines changed

.github/pull_request_template.md

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,26 @@
11
# Description of the changes
22

3+
4+
Check all that apply:
5+
- [ ] added [release notes](https://github.com/neutrons/usansred/blob/next/docs/source/releases.rst) (if not, provide an explanation in the work description)
6+
- [ ] updated documentation
7+
- [ ] Source added/refactored
8+
- [ ] Added unit tests
9+
- [ ] Added integration tests
10+
- [ ] Verified that tests requiring the /SNS and /HFIR filesystems pass without fail
11+
12+
**References:**
13+
- Links to IBM EWM items:
14+
- Links to related issues or pull requests:
15+
316
# Manual test for the reviewer
417
<!-- Instructions for testing here. -->
518

619
# Check list for the reviewer
20+
- [ ] [release notes](https://github.com/neutrons/usansred/blob/next/docs/source/releases.rst) updated, or an explanation is provided as to why release notes are unnecessary
721
- [ ] best software practices
822
+ [ ] clearly named variables (better to be verbose in variable names)
923
+ [ ] code comments explaining the intent of code blocks
1024
- [ ] All the tests are passing
1125
- [ ] The documentation is up to date
1226
- [ ] code comments added when explaining intent
13-
-
14-
# Check list for the pull request
15-
- [ ] source refactored/incremented
16-
- [ ] tests for my changes
17-
- [ ] updated the documentation accordingly
18-
19-
# References
20-
<!-- Links to related issues or pull requests -->
21-
<!-- Links to IBM EWM items if aaplicable -->

docs/source/releases.rst

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,24 @@
33
Release Notes
44
=============
55

6+
<Next Release>
7+
--------------
8+
(date of release)
9+
10+
**Of interest to the User**:
11+
12+
- PR #XYZ: one-liner description
13+
14+
**Of interest to the Developer:**
15+
16+
- PR #12: switch from mantid to mantidworkbench conda package
17+
618
1.0.0
719
-----
20+
2024-05-06
21+
22+
This is the first release of USANSRED.
23+
824
- repository implements the `OpenSSF Best Practices Badge Program <https://www.bestpractices.dev/en/criteria/0>`_
925
- codecov reports for every accepted change, uploaded to `codecov usansred <https://app.codecov.io/gh/neutrons/usansred>`_
1026
- generation of conda packages, uploaded to the `neutrons channel <https://anaconda.org/neutrons/usansred/files>`_

environment.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,9 @@ channels:
66
dependencies:
77
- python=3.10
88
- versioningit
9-
- mantid=6.9.1
10-
- numpy
11-
- scipy
9+
- mantidworkbench=6.9.1
1210
- pandas
1311
- xlsxwriter
14-
- matplotlib
1512
- pip
1613
- pip:
1714
- git+https://github.com/peterfpeterson/[email protected]

0 commit comments

Comments
 (0)