Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[defect] Mantid GenerateEventsFilter wrongfully determined the run end time #25

Open
glass-ships opened this issue Dec 17, 2024 · 1 comment

Comments

@glass-ships
Copy link
Member

Problem Description:

In the GenerateEventsFilter when the user determines the the function will always determine the run end time with proton time but not the run end time or last event time, even these are specified in the function options.

Steps to Reproduce:

One has to remove the proton time or change to desired value in the workspace to change the end time in GenerateEventsFilter.

Investigation/Analysis Results:

In the associate function definition as in
https://github.com/mantidproject/mantid/blob/929450b9d01488869be7a5c1fa6f2774bcbfd325/Framework/Algorithms/src/GenerateEventsFilter.cpp#L1776

In the comments, it is clearly denoted as,

/** Find run end time. Here is how the run end time is defined ranked from

  • highest priority
    1. Run.endTime()
    1. Last proton charge log time
    1. Last event time
  • In order to consider the events in the last pulse,
    1. if proton charge does exist, then run end time will be extended by 1
  • pulse time
    1. otherwise, extended by 0.1 second (10 Hz)
  • Exception: None of the 3 conditions is found to determine run end time
    */

But in the code, the logic flows of the following if's overrides the previous ones.

@glass-ships
Copy link
Member Author

This issue was migrated from code.ornl.gov.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant