Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not overwrite Qmax upon loading in a new S(Q) for plot #61

Open
marshallmcdonnell opened this issue Dec 14, 2016 · 1 comment
Open
Assignees
Labels
GUI: Calcualte G(r) Tab The Calculate G(r) Tab Priority: Medium Medium priority feature / fix Type: Enhancement Added feature or enhancement of current features

Comments

@marshallmcdonnell
Copy link
Member

marshallmcdonnell commented Dec 14, 2016

When we load an S(Q) plot, the GUI restores the Qmax along with other options as well. We should keep current state of these variables and instead have a buttong that says something like 'Restore default settings/options'.

It is more common to find a common Qmax and load multiple S(Q) using the same parameters than to restore them and have to re-type them in every time.

@marshallmcdonnell marshallmcdonnell added Type: Enhancement Added feature or enhancement of current features Status: Ready Ready for review labels Dec 14, 2016
@marshallmcdonnell
Copy link
Member Author

To elaborate and show what we mean about the Qmax options, here is a demonstration of what occurs now:

  1. We set a Qmax we want to use for the Fourier Transform to get G(r)
    part1

  2. Then, we load in S(Q) files (the multi-selection feature was added in commit 7ec1a97)
    part2

  3. When we load the files in, we lose the Qmax we set and the G(r) produced use the default Qmax of 31.4 (instead of the Qmax=20)
    part3

We want to keep the Qmax (and other opitions) set when loading in S(Q) and when we want to restore to the default, have a button to press to do so. Something like 'Restore default setttings'.

@wdzhou wdzhou added the Status: Help Wanted Needs attention from others; work is stuck as WIP label Apr 27, 2017
@marshallmcdonnell marshallmcdonnell added GUI: Calcualte G(r) Tab The Calculate G(r) Tab Priority: Medium Medium priority feature / fix and removed Status: Help Wanted Needs attention from others; work is stuck as WIP Status: Ready Ready for review labels Sep 30, 2019
@marshallmcdonnell marshallmcdonnell changed the title Calculate G(r) Tab - do not overwrite Qmax upon loading in a new S(Q) for plot Do not overwrite Qmax upon loading in a new S(Q) for plot Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI: Calcualte G(r) Tab The Calculate G(r) Tab Priority: Medium Medium priority feature / fix Type: Enhancement Added feature or enhancement of current features
Projects
None yet
Development

No branches or pull requests

2 participants