Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue on page /examples/ecg_delineate/ecg_delineate.html #1056

Open
awhittle3 opened this issue Dec 8, 2024 · 3 comments
Open

Issue on page /examples/ecg_delineate/ecg_delineate.html #1056

awhittle3 opened this issue Dec 8, 2024 · 3 comments
Labels
wontfix This will not be worked on

Comments

@awhittle3
Copy link

Inconsistent sampling rate used in examples for ecg_delineate

This seems to be a fairly minor documentation issue that could cause confusion. The issue seems to come from this notebook: https://github.com/neuropsychology/NeuroKit/blob/45c9ad90d863ebf4e9d043b975a10d9f8fdeb06b/docs/examples/ecg_delineate/ecg_delineate.ipynb

  • Stated sampling rate:

In this example, we will use a short segment of ECG signal with sampling rate of 3000 Hz.

  • Data imported with ecg_signal = nk.data(dataset="ecg_1000hz")
  • "Find the R peaks" uses sampling_rate=1000
  • "Peak method" uses sampling_rate=1000
  • "Continuous Wavelet Method (CWT)" uses sampling_rate=1000
  • "Discrete Wavelet Method (DWT) - default method" uses sampling_rate=3000
Copy link

welcome bot commented Dec 8, 2024

Hi 👋 Thanks for reaching out and opening your first issue here! We'll try to come back to you as soon as possible. ❤️ kenobi

@DominiqueMakowski
Copy link
Member

Good catch, could you make a PR to fix that? Thanks!

Copy link

stale bot commented Feb 24, 2025

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix This will not be worked on label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants