Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Fix the broken transit shape by applying transit routing changes #390

Open
yueshuaing opened this issue Oct 11, 2024 · 1 comment
Open
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@yueshuaing
Copy link
Collaborator

User Story

In Metcouncil future year workflows, some roadway project cards remove roadways that have transit lines running on them. Currently, NW stops if any roadway changes break the existing transit routes. We'd like to have the feature that allows using the transit routing changes to fix the route after applying the roadway deletion.

Priority

To Reproduce

Run pytest tests\test_scenario.py
The function to test is test_scenario_apply_highway_and_transit_changes

@yueshuaing yueshuaing added the enhancement New feature or request label Oct 11, 2024
@e-lo
Copy link
Collaborator

e-lo commented Oct 16, 2024

NW stops if any roadway changes break the existing transit routes.

Yeah, this isn't actually a good default behavior and I'd consider it a bug. Rather, we should present a warning.
Consider a roadway change that splits a link and a transit change that fixes it or reroutes around the split link. They are dependent on each other and thus should be applied as co-requisites or even within the same project file. That said, when the change is made to transit the resulting highway network is not updated with the new link yet. Or if we change transit first, it will try and route it on a link that doesn't yet exist creating a chicken-and-egg issue which can only be solved by splitting up the changes into 1. add new link. 2. reroute transit 2. delete old link. This sucks as a user experience.

Therefore, I'm changing the default behavior to a warning which should require the user to review what was going on.

e-lo added a commit that referenced this issue Oct 16, 2024
Fixes #389  and the test that it was using
Downgrades error to warning for deleting roadways with transit so can apply changes see discussion in #390
Adds back all geojson files which were accidentally added to .gitignore
Updates API for project cards to be consistent with project card v3.3.3
Deletes extraneous file validation_failure_cases.csv
Moves all roadway selection logic from the data models to selection classes
Updates several notebooks with current API
@e-lo e-lo added this to the v1.1 milestone Oct 28, 2024
@e-lo e-lo changed the title [FEATURE] Fix the broken transit shape by applying transit routing changes 🚀 Fix the broken transit shape by applying transit routing changes Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants