You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In Metcouncil future year workflows, some roadway project cards remove roadways that have transit lines running on them. Currently, NW stops if any roadway changes break the existing transit routes. We'd like to have the feature that allows using the transit routing changes to fix the route after applying the roadway deletion.
Priority
To Reproduce
Run pytest tests\test_scenario.py
The function to test is test_scenario_apply_highway_and_transit_changes
The text was updated successfully, but these errors were encountered:
NW stops if any roadway changes break the existing transit routes.
Yeah, this isn't actually a good default behavior and I'd consider it a bug. Rather, we should present a warning.
Consider a roadway change that splits a link and a transit change that fixes it or reroutes around the split link. They are dependent on each other and thus should be applied as co-requisites or even within the same project file. That said, when the change is made to transit the resulting highway network is not updated with the new link yet. Or if we change transit first, it will try and route it on a link that doesn't yet exist creating a chicken-and-egg issue which can only be solved by splitting up the changes into 1. add new link. 2. reroute transit 2. delete old link. This sucks as a user experience.
Therefore, I'm changing the default behavior to a warning which should require the user to review what was going on.
Fixes#389 and the test that it was using
Downgrades error to warning for deleting roadways with transit so can apply changes see discussion in #390
Adds back all geojson files which were accidentally added to .gitignore
Updates API for project cards to be consistent with project card v3.3.3
Deletes extraneous file validation_failure_cases.csv
Moves all roadway selection logic from the data models to selection classes
Updates several notebooks with current API
e-lo
changed the title
[FEATURE] Fix the broken transit shape by applying transit routing changes
🚀 Fix the broken transit shape by applying transit routing changes
Oct 28, 2024
User Story
In Metcouncil future year workflows, some roadway project cards remove roadways that have transit lines running on them. Currently, NW stops if any roadway changes break the existing transit routes. We'd like to have the feature that allows using the transit routing changes to fix the route after applying the roadway deletion.
Priority
To Reproduce
Run
pytest tests\test_scenario.py
The function to test is
test_scenario_apply_highway_and_transit_changes
The text was updated successfully, but these errors were encountered: