Skip to content

Commit 4cdbf21

Browse files
AmygosAmygos
committed
tests: add required fqdn to configure-module cases
In order to align with the updated JSON schema, all related Robot Framework tests now explicitly include the `fqdn` property as a required field in configure-module payloads. This change ensures validations for address, NAT handling, service networks, local networks, and Let's Encrypt logic are executed with the mandatory context provided by fqdn.
1 parent ae3bf9c commit 4cdbf21

File tree

2 files changed

+17
-23
lines changed

2 files changed

+17
-23
lines changed

‎tests/10_actions/00_configure_module_validate.robot‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,44 +6,44 @@ Resource ../api.resource
66

77
FQDN cannot be empty
88
${response} = Run task module/${module_id}/configure-module
9-
... {"fqdn": ""} rc_expected=10 decode_json=False
9+
... {"fqdn": "", "addresses": {"address": "127.0.0.1"}} rc_expected=10 decode_json=False
1010

1111
FQDN must be a valid domain name
1212
${response} = Run task module/${module_id}/configure-module
13-
... {"fqdn": "example@#$"} rc_expected=10 decode_json=False
13+
... {"fqdn": "example@#$", "addresses": {"address": "127.0.0.1"}} rc_expected=10 decode_json=False
1414

1515
Address in addresses configuration is required
1616
${response} = Run task module/${module_id}/configure-module
17-
... {"addresses": {"public_address": "127.0.0.1"}} rc_expected=10 decode_json=False
17+
... {"fqdn": "example.com", "addresses": {"public_address": "127.0.0.1"}} rc_expected=10 decode_json=False
1818

1919
Address and public_address in addresses configuration must be a valid address
2020
${response} = Run task module/${module_id}/configure-module
21-
... {"addresses": {"address": "A", "public_address": "B"}} rc_expected=10 decode_json=False
21+
... {"fqdn": "example.com", "addresses": {"address": "A", "public_address": "B"}} rc_expected=10 decode_json=False
2222

2323
Service network's configuration must present if service_network is present
2424
${response} = Run task module/${module_id}/configure-module
25-
... {"addresses": {"address": "127.0.0.1"}, "service_network": {}} rc_expected=10 decode_json=False
25+
... {"fqdn": "example.com", "addresses": {"address": "127.0.0.1"}, "service_network": {}} rc_expected=10 decode_json=False
2626

2727
Service network's address and netmask must both be present
2828
${response} = Run task module/${module_id}/configure-module
29-
... {"addresses": {"address": "127.0.0.1"}, "service_network": {"address": "10.5.4.0.1"}} rc_expected=10 decode_json=False
29+
... {"fqdn": "example.com", "addresses": {"address": "127.0.0.1"}, "service_network": {"address": "10.5.4.0.1"}} rc_expected=10 decode_json=False
3030
${response} = Run task module/${module_id}/configure-module
31-
... {"addresses": {"address": "127.0.0.1"}, "service_network": {"netmask": "10.5.4.0/24"}} rc_expected=10 decode_json=False
31+
... {"fqdn": "example.com", "addresses": {"address": "127.0.0.1"}, "service_network": {"netmask": "10.5.4.0/24"}} rc_expected=10 decode_json=False
3232

3333
Service network's address and netmask must be valid
3434
${response} = Run task module/${module_id}/configure-module
35-
... {"addresses": {"address": "127.0.0.1"}, "service_network": {"address": "A", "netmask": "10.5.4.0/24"}} rc_expected=10 decode_json=False
35+
... {"fqdn": "example.com", "addresses": {"address": "127.0.0.1"}, "service_network": {"address": "A", "netmask": "10.5.4.0/24"}} rc_expected=10 decode_json=False
3636
${response} = Run task module/${module_id}/configure-module
37-
... {"addresses": {"address": "127.0.0.1"}, "service_network": {"address": "10.5.4.1", "netmask": "A"}} rc_expected=2 decode_json=False
37+
... {"fqdn": "example.com", "addresses": {"address": "127.0.0.1"}, "service_network": {"address": "10.5.4.1", "netmask": "A"}} rc_expected=2 decode_json=False
3838

3939
Networks in local networks list must be valid
4040
${response} = Run task module/${module_id}/configure-module
41-
... {"local_networks": ["A"]} rc_expected=3 decode_json=False
41+
... {"fqdn": "example.com", "addresses": {"address": "127.0.0.1"}, "local_networks": ["A"]} rc_expected=3 decode_json=False
4242

4343
lets_encrypt field must be a boolean
4444
${response} = Run task module/${module_id}/configure-module
45-
... {"lets_encrypt": "A"} rc_expected=10 decode_json=False
45+
... {"fqdn": "example.com", "addresses": {"address": "127.0.0.1"}, "lets_encrypt": "A"} rc_expected=10 decode_json=False
4646

4747
Lets encrypt can be enabled only with valid FQDN
4848
${response} = Run task module/${module_id}/configure-module
49-
... {"fqdn": "example.com", "lets_encrypt": true} rc_expected=3 decode_json=False
49+
... {"fqdn": "example.com", "addresses": {"address": "127.0.0.1"}, "lets_encrypt": true} rc_expected=3 decode_json=False

‎tests/10_actions/10_configure_integrations.robot‎

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,12 @@ Library String
55
Resource ../api.resource
66

77
*** Test Cases ***
8-
Set an address
8+
Set a FQDN without let's encrypt and address an without NAT
99
Run task module/${module_id}/configure-module
10-
... {"addresses": {"address": "${local_ip}"}}
10+
... {"fqdn": "example.com", "lets_encrypt": false, "addresses": {"address": "${local_ip}"}}
1111
${response} = Run task module/${module_id}/get-configuration
1212
... {}
13+
Should Be Equal ${response["fqdn"]} example.com
1314
Should Be Equal ${response["addresses"]} ${{ {"address": "${local_ip}"} }}
1415
Should Be Empty ${response['local_networks']}
1516
${response} = Run task module/${module_id}/list-service-providers
@@ -19,9 +20,9 @@ Set an address
1920
... {"service": "sip", "transport": "udp", "filter": {"module_id": "${module_id}"} }
2021
Should Be Equal ${response[0]['address']} ${local_ip}
2122

22-
Set an address behind NAT
23+
Set a FQDN without let's encrypt and an address with NAT
2324
Run task module/${module_id}/configure-module
24-
... {"addresses": {"address": "${local_ip}", "public_address": "1.2.3.4"}, "local_networks": ["10.20.30.0/24"]}
25+
... {"fqdn": "example.com", "lets_encrypt": false, "addresses": {"address": "${local_ip}", "public_address": "1.2.3.4"}, "local_networks": ["10.20.30.0/24"]}
2526
${response} = Run task module/${module_id}/get-configuration
2627
... {}
2728
Should Be Equal ${response["addresses"]} ${{ {"address": "${local_ip}", "public_address": "1.2.3.4"} }}
@@ -35,10 +36,3 @@ Set an address behind NAT
3536
... {"service": "sip", "transport": "udp", "filter": {"module_id": "${module_id}"} }
3637
Should Be Equal ${response[0]['address']} ${local_ip}
3738
Should Be Equal ${response[0]['public_address']} 1.2.3.4
38-
39-
Set FQDN to a valid value
40-
Run task module/${module_id}/configure-module
41-
... {"fqdn": "example.com", "lets_encrypt": false}
42-
${response} = Run task module/${module_id}/get-configuration
43-
... {}
44-
Should Be Equal ${response["fqdn"]} example.com

0 commit comments

Comments
 (0)