Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Map It Button Link is broken when used a foreign language that uses comma as decimal separator #16202

Closed
marcusyuri opened this issue May 20, 2024 · 0 comments · Fixed by #16270
Closed

Google Map It Button Link is broken when used a foreign language that uses comma as decimal separator #16202

marcusyuri opened this issue May 20, 2024 · 0 comments · Fixed by #16270
Assignees
@arthanson
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@marcusyuri
Copy link

Deployment Type

Self-hosted

NetBox Version

v4.0.2

Python Version

3.10

Steps to Reproduce

  1. Change user language preference to "Portuguese"
  2. Create or edit a site and fill the latitude / longitude with decimal values, separated by COMMA and save
  3. Press the 'map it' button

Expected Behavior

The google maps tab opens with the correct latitude / longitude spotted.

Observed Behavior

The google maps site will apper in a new tab, but with error message "O Google Maps não encontrou xxxx,yyyy".
This appears to be caused by Google Maps expecting the latitude / longitude values to use PERIOD decimal separator, instead of the COMMA separator. Maybe a simple conversion to US locale when generating the Map It button link can solve this.
@marcusyuri marcusyuri added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels May 20, 2024
@jeremystretch jeremystretch removed their assignment May 21, 2024
@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: needs triage This issue is awaiting triage by a maintainer labels May 21, 2024
@arthanson arthanson self-assigned this May 23, 2024
@arthanson arthanson removed the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label May 23, 2024
@arthanson arthanson mentioned this issue May 23, 2024
Merged
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label May 28, 2024
@jeremystretch jeremystretch mentioned this issue May 28, 2024
Closed
jeremystretch added a commit that referenced this issue May 31, 2024
@jeremystretch
Changelog for #13422, #14810, #15489, #16202, #16286, #16290
26a856f
@jeremystretch jeremystretch mentioned this issue Jun 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arthanson arthanson

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

16202 fix mapit button for internationalized decimal seperator netbox-community/netbox
3 participants
@arthanson @jeremystretch @marcusyuri