Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: netblue30/firejail
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.9.66
Choose a base ref
...
head repository: netblue30/firejail
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Loading
Showing 1,703 changed files with 42,206 additions and 23,367 deletions.
34 changes: 34 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
root = true

[*]
charset = utf-8
end_of_line = lf
insert_final_newline = true
trim_trailing_whitespace = true

# Build
[configure.ac]
indent_size = 8
indent_style = tab

[*{.mk,Makefile}{,.in}]
indent_size = 8
indent_style = tab

# Source code and scripts
[*.{c,h}{,.in}]
indent_size = 8
indent_style = tab

[*.{awk,exp,sh}{,.in}]
indent_size = 8
indent_style = tab

[*.py{,.in}]
indent_size = 4
indent_style = space

# Misc
[.gitlab-ci.yml]
indent_size = 4
indent_style = space
35 changes: 35 additions & 0 deletions .git-blame-ignore-revs
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
# Note: Entries (and sections) should be listed in topological order (that is,
# in the same order that is shown by `git log --oneline`) and they can be
# generated with one of the following commands:
#
# TZ=UTC0 git show --date='format-local:%Y-%m-%d' --pretty='%H # %cd | %s' -s
# [<commit>...]
#
# TZ=UTC0 git log --date='format-local:%Y-%m-%d' --pretty='%H # %cd | %s'
# [<revision-range>]

# Landlock v1
97874c3bf923798b0e3ab119d169aaa9b1314221 # 2022-09-05 | Revert "Merge pull request #5315 from ChrysoliteAzalea/landlock"
b900bdc87463d79568aef46cb7e3b373fbff84b1 # 2022-09-05 | Revert "compile fix"
bfcacff665b750ae7b9fc984496df26fcd7cc53d # 2022-09-05 | Revert "tracelog disabled by default in /etc/firejail/firejail.config file"
2a79f3a2689711e6151187063bb55a6af3160b6f # 2022-09-05 | Revert "README/README.md"
67348ac9c2cdf9d30efbf9fd13eaf0a4adc3be00 # 2022-09-05 | Revert "typos"
0cd20b7e81a7815f57055b38f0746ef14fed2cd0 # 2022-09-05 | Revert "fix syntax in configure.ac"
26c74796f3c76b8f0ea0b95a863eb707ecced195 # 2022-09-05 | Revert "landlock: check for landlock support in glibc"
5b206611c01e42a6d63c596be45bcf085832b035 # 2022-09-05 | Revert "landlock: support in firejail --version"
2f3c19a87dd49b220f69f27f8c14c627277355d6 # 2022-09-04 | landlock: support in firejail --version
c5a052ffa4e2ccaf240635db116a49986808a2b6 # 2022-09-04 | landlock: check for landlock support in glibc
2d885e5a091f847d7c2128506947b0f67dd2edab # 2022-09-04 | fix syntax in configure.ac
0594c5d3d0f1ddc4049cf2ed38676a1cdc8d6843 # 2022-08-30 | typos
796fa09636195d8751a7bbc1e1bc88bf8c3ac95a # 2022-08-30 | README/README.md
6e687c30110a52f267c1779c4eeab82bded9cb77 # 2022-08-29 | tracelog disabled by default in /etc/firejail/firejail.config file
836ffe37ff891886f15243eacc70963368d57a3f # 2022-08-29 | compile fix
c6d7474c138f92b3cb3992b5c57750af89eb3b77 # 2022-08-16 | tinyLL has been removed as it's no longer needed
460fa7a6f98cc1e7aec2953e6523f32677d546c7 # 2022-08-16 | Proposed fixes.
877fc99d541af83a9486dfff43580e33dedd8b4c # 2022-08-15 | Update quotation marks in src/zsh_completion/_firejail.in
ba828befe06b99b7dc2d504085cb40aa2d710998 # 2022-08-15 | Landlock functions are added to the code of Firejail, removing the dependency on tinyLL
61b15442898eeb1db2d23b6b2eb72a705ceb368a # 2022-08-15 | Landlock support has been added.

# "move whitelist/blacklist to allow/deny"
f43382f1e9707b4fd5e63c7bfe881912aa4ee994 # 2021-07-18 | Revert "move whitelist/blacklist to allow/deny"
fe0f975f447d59977d90c3226cc8c623b31b20b3 # 2021-07-05 | move whitelist/blacklist to allow/deny
6 changes: 6 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
* text=auto eol=lf

*.AppImage -text
*.zip -text

/etc/inc/*.inc linguist-language=text
3 changes: 3 additions & 0 deletions .github/.editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[*.yml]
indent_size = 2
indent_style = space
106 changes: 78 additions & 28 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -6,44 +6,94 @@ labels: ''
assignees: ''

---
Write clear, concise and in textual form.

**Bug and expected behavior**
- Describe the bug.
- What did you expect to happen?
<!--
See the following links for help with formatting:
**No profile and disabling firejail**
- What changed calling `firejail --noprofile /path/to/program` in a terminal?
- What changed calling the program by path (e.g. `/usr/bin/vlc`)?
https://guides.github.com/features/mastering-markdown/
https://docs.github.com/en/github/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax
-->

**Reproduce**
Steps to reproduce the behavior:
1. Run in bash `firejail PROGRAM`
2. See error `ERROR`
3. Click on '....'
4. Scroll down to '....'
### Description

**Environment**
- Linux distribution and version (ie output of `lsb_release -a`, `screenfetch` or `cat /etc/os-release`)
- Firejail version (output of `firejail --version`) exclusive or used git commit (`git rev-parse HEAD`)
_Describe the bug_

**Additional context**
Other context about the problem like related errors to understand the problem.
### Steps to Reproduce

**Checklist**
- [ ] The profile (and redirect profile if exists) hasn't already been fixed [upstream](https://github.com/netblue30/firejail/tree/master/etc).
- [ ] The program has a profile. (If not, request one in `https://github.com/netblue30/firejail/issues/1139`)
- [ ] I have performed a short search for similar issues (to avoid opening a duplicate).
- [ ] If it is a AppImage, `--profile=PROFILENAME` is used to set the right profile.
- [ ] Used `LC_ALL=en_US.UTF-8 LANG=en_US.UTF-8 PROGRAM` to get english error-messages.
- [ ] I'm aware of `browser-allow-drm yes`/`browser-disable-u2f no` in `firejail.config` to allow DRM/U2F in browsers.
- [ ] This is not a question. Questions should be asked in https://github.com/netblue30/firejail/discussions.
_Steps to reproduce the behavior_

1. Run in bash `LC_ALL=C firejail /path/to/program` (`LC_ALL=C` to get a consistent
output in English that can be understood by everybody)
2. Click on '....'
3. Scroll down to '....'
4. See error `ERROR`

<details><summary> debug output </summary>
### Expected behavior

_What you expected to happen_

### Actual behavior

_What actually happened_

### Behavior without a profile

_What changed calling `LC_ALL=C firejail --noprofile /path/to/program` in a
terminal?_

### Additional context

_Any other detail that may help to understand/debug the problem_

### Environment

- Name/version/arch of the Linux kernel (`uname -srm`):
- Name/version of the Linux distribution (e.g. "Ubuntu 20.04" or "Arch Linux"):
- Name/version of the relevant program(s)/package(s) (e.g. "firefox 134.0-1,
mesa 1:24.3.3-2"):
- Version of Firejail (`firejail --version`):
- If you use a development version of firejail, also the commit from which it
was compiled (`git rev-parse HEAD`):

### Checklist

<!--
Note: Items are checked with an "x", like so:
- [x] This is a checked item.
-->

- [ ] The issues is caused by firejail (i.e. running the program by path (e.g. `/usr/bin/vlc`) "fixes" it).
- [ ] I can reproduce the issue without custom modifications (e.g. globals.local).
- [ ] The program has a profile. (If not, request one in `https://github.com/netblue30/firejail/issues/1139`)
- [ ] The profile (and redirect profile if exists) hasn't already been fixed [upstream](https://github.com/netblue30/firejail/tree/master/etc).
- [ ] I have performed a short search for similar issues (to avoid opening a duplicate).
- [ ] I'm aware of `browser-allow-drm yes`/`browser-disable-u2f no` in `firejail.config` to allow DRM/U2F in browsers.
- [ ] I used `--profile=PROFILENAME` to set the right profile. (Only relevant for AppImages)

### Log

<details>
<summary>Output of <code>LC_ALL=C firejail /path/to/program</code></summary>
<p>

```
output goes here
```

</p>
</details>

<details>
<summary>Output of <code>LC_ALL=C firejail --debug /path/to/program</code></summary>
<p>

<!-- If the output is too long to embed it into the comment,
create a secret gist at https://gist.github.com/ and link it here. -->

```
OUTPUT OF `firejail --debug PROGRAM`
output goes here
```

</p>
</details>
73 changes: 73 additions & 0 deletions .github/ISSUE_TEMPLATE/build_issue.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
---
name: Build issue
about: There is an issue when trying to build the project from source
title: 'build: '
labels: ''
assignees: ''

---

<!--
See the following links for help with formatting:
https://guides.github.com/features/mastering-markdown/
https://docs.github.com/en/github/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax
-->

### Description

_Describe the bug_

### Steps to Reproduce

<!--
Note: If the output is too long to embed it into the comment, you can post it
in a gist at <https://gist.github.com/> and link it here or upload the build
log as a file.
Note: Make sure to include the exact command-line used for all commands and to
include the full output of ./configure.
Feel free to include only the errors in the make output if they are
self-explanatory (for example, with `make >/dev/null`).
-->

_Post the commands used to reproduce the issue and their output_

Example:

```console
$ ./configure --prefix=/usr --enable-apparmor
checking for gcc... gcc
checking whether the C compiler works... yes
[...]
$ make
make -C src/lib
gcc [...]
[...]
```

_If ./configure fails, include the output of config.log_

Example:

```console
$ cat config.log
This file contains any messages produced by compilers while
running configure, to aid debugging if configure makes a mistake.
[...]
```

### Additional context

_(Optional) Any other detail that may help to understand/debug the problem_

### Environment

- Name/version/arch of the Linux kernel (`uname -srm`):
- Name/version of the Linux distribution (e.g. "Ubuntu 20.04" or "Arch Linux"):
- Name/version of the C compiler (e.g. "gcc 14.1.1-1"):
- Name/version of the libc (e.g. "glibc 2.40-1"):
- Name/version of the Linux API headers (e.g. "linux-api-headers 6.10-1" on
Arch Linux):
- Version of the source code being built (`git rev-parse HEAD`):
5 changes: 5 additions & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
blank_issues_enabled: true
contact_links:
- name: Question
url: https://github.com/netblue30/firejail/discussions
about: For questions you should use GitHub Discussions.
32 changes: 32 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
---
name: Feature request
about: Suggest an idea for this project
title: ''
labels: ''
assignees: ''

---

### Is your feature request related to a problem? Please describe.

_A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]_

### Describe the solution you'd like

_A clear and concise description of what you want to happen._

### Describe alternatives you've considered

_A clear and concise description of any alternative solutions or features you've considered._

### Additional context

_Add any other context or screenshots about the feature request here._

### Environment

- Name/version/arch of the Linux kernel (`uname -srm`):
- Name/version of the Linux distribution (e.g. "Ubuntu 20.04" or "Arch Linux"):
- Version of Firejail (`firejail --version`):
- If you use a development version of firejail, also the commit from which it:
was compiled (`git rev-parse HEAD`):
7 changes: 7 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
version: 2
updates:
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "monthly"
open-pull-requests-limit: 4
29 changes: 16 additions & 13 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,21 @@
If your PR isn't about profiles or you have no idea how to do one of these,
skip the following and go ahead with this PR.

If your PR isn't about profiles or you have no idea how to do one of these, skip the following and go ahead with this PR.
If you submit a PR for new profiles or changing profiles, please do the
following:

If you submit a PR for new profiles or changing profiles, please do the following:
- The ordering of options follow the rules described in [/usr/share/doc/firejail/profile.template](https://github.com/netblue30/firejail/blob/master/etc/templates/profile.template).
> Hint: The profile-template is very new. If you install firejail with your package manager, it may be missing. In order to follow the latest rules, it is recommended to use the template from the repository.
- Order the arguments of options alphabetically. You can easily do this with [sort.py](https://github.com/netblue30/firejail/tree/master/contrib/sort.py).
The path to it depends on your distro:
- The ordering of options follow the rules described in
[etc/templates/profile.template](../blob/master/etc/templates/profile.template)
(/usr/share/doc/firejail/profile.template when installed).
- Order the arguments of options alphabetically. You can easily do this with
[sort.py](../blob/master/contrib/sort.py).

| Distro | Path |
| ------ | ---- |
| Arch/Fedora | `/usr/lib64/firejail/sort.py` |
| Debian/Ubuntu/Mint | `/usr/lib/x86_64-linux-gnu/firejail/sort.py` |
| local git clone | `contrib/sort.py` |
The path to it depends on your distro:

Note also that the sort.py script exists only since firejail `0.9.61`.
| Distro | Path |
| ------ | ---- |
| Arch/Fedora | `/usr/lib64/firejail/sort.py` |
| Debian/Ubuntu/Mint | `/usr/lib/x86_64-linux-gnu/firejail/sort.py` |
| local git clone | `contrib/sort.py` |

See also [CONTRIBUTING.md](/CONTRIBUTING.md).
See also [CONTRIBUTING.md](../blob/master/CONTRIBUTING.md).
Loading