Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Rspack section in Hot reload documentation #2896

Open
1 task done
hardfist opened this issue Oct 25, 2023 · 4 comments
Open
1 task done

add Rspack section in Hot reload documentation #2896

hardfist opened this issue Oct 25, 2023 · 4 comments

Comments

@hardfist
Copy link

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

We(Rspack team) receives lots of issues and questions about how to use Rspack bundle Nest application and support Hot Reload, even we have a section about Nest in our website(https://www.rspack.dev/guide/nestjs.html), I think it maybe helpful Nest documentation have a Rspack section about it too.

Describe the solution you'd like

add a Rspack section in Nest documentation

Teachability, documentation, adoption, migration strategy

similar to current webpack section

What is the motivation / use case for changing the behavior?

No Change

@Tony133
Copy link
Contributor

Tony133 commented Oct 26, 2023

Personally, instead of adding a section, I would add a notice with a link to the rspack, so as to avoid having too many third party documents to maintain.

Or add something like this in the section regarding hot-reload:

Third-party libraries
  - Rspack (link to Rspack documentation)

@kamilmysliwiec kamilmysliwiec transferred this issue from nestjs/nest Oct 26, 2023
@hardfist
Copy link
Author

Personally, instead of adding a section, I would add a notice with a link to the rspack, so as to avoid having too many third party documents to maintain.

Or add something like this in the section regarding hot-reload:

Third-party libraries
  - Rspack (link to Rspack documentation)

that sounds good to me

@Tony133
Copy link
Contributor

Tony133 commented Nov 3, 2023

@hardfist do you want to create a PR for this issue ?

@hardfist
Copy link
Author

hardfist commented Nov 3, 2023

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants