Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Dashboard #132

Open
4 tasks
renovate bot opened this issue Aug 30, 2021 · 2 comments
Open
4 tasks

Dependency Dashboard #132

renovate bot opened this issue Aug 30, 2021 · 2 comments

Comments

@renovate
Copy link
Contributor

renovate bot commented Aug 30, 2021

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Config Migration Needed

  • Select this checkbox to let Renovate create an automated Config Migration PR.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

Detected dependencies

npm
package.json
  • @commitlint/cli 19.6.1
  • @commitlint/config-angular 19.6.0
  • @nestjs/common 10.4.15
  • @nestjs/core 10.4.15
  • @nestjs/platform-express 10.4.15
  • @nestjs/testing 10.4.15
  • @types/jest 29.5.14
  • @types/node 22.10.2
  • @typescript-eslint/eslint-plugin 8.18.0
  • @typescript-eslint/parser 8.18.0
  • axios 1.7.9
  • eslint 9.17.0
  • eslint-config-prettier 9.1.0
  • eslint-plugin-import 2.31.0
  • husky 9.1.7
  • jest 29.7.0
  • lint-staged 15.2.11
  • prettier 3.4.2
  • reflect-metadata 0.2.2
  • release-it 17.10.0
  • rimraf 6.0.1
  • rxjs 7.8.1
  • ts-jest 29.2.5
  • typescript 5.7.2
  • @nestjs/common ^7.0.0 || ^8.0.0 || ^9.0.0 || ^10.0.0
  • axios ^1.3.1
  • rxjs ^6.0.0 || ^7.0.0

  • Check this box to trigger a request for Renovate to run again on this repository
@thgh
Copy link

thgh commented Aug 24, 2022

Is there anything blocking to upgrade Axios to 1.0.0?

@FahriDevZ
Copy link

Is there anything blocking to upgrade Axios to 1.0.0?

axios v1 use AbortController instead of Axios.CancelToken.source

maybe HttpService like

export class HttpService {
  // ...

  protected makeObservable<T>(
    axios: (...args: any[]) => AxiosPromise<T>,
    ...args: any[]
  ) {
    return new Observable<AxiosResponse<T>>(subsriber => {
      const config: AxiosRequestConfig = { ...(args[args.length - 1] || {}) };

      let controller: AbortController;
      if (!config.signal) {
        controller = new AbortController();
        config.signal = controller.signal;
      }

      axios(...args)
        .then(res => {
          subsriber.next(res);
          subsriber.complete();
        }).catch(err => {
          subsriber.error(err);
        });

      return () => {
        if (config.responseType === 'stream') {
          return;
        }

        if (controller) {
          controller.abort();
        }
      }
    });
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants