Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add list view for XUDT and RGB++ List #1619

Merged
merged 20 commits into from
May 29, 2024

Conversation

devchenyan
Copy link

Copy link

vercel bot commented May 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ckb-explorer-frontend-in-nervosnetwork-repo ✅ Ready (Inspect) Visit Preview May 27, 2024 3:45pm

src/locales/en.json Outdated Show resolved Hide resolved
src/locales/zh.json Outdated Show resolved Hide resolved
src/pages/Address/Cells.tsx Outdated Show resolved Hide resolved
src/services/ExplorerService/fetcher.ts Outdated Show resolved Hide resolved
src/pages/Address/RgbppAssets.tsx Outdated Show resolved Hide resolved
@devchenyan
Copy link
Author

https://ckb-explorer-frontend-in-nervosnetwork-re-git-a37ef3-magickbase.vercel.app/en/address/ckt1qrejnmlar3r452tcg57gvq8patctcgy8acync0hxfnyka35ywafvkqgjvmm4mjsafx7etwzhn5d3vun6sxpeexruqq2sgnfp image 1、When the data is empty, the / symbol needs to be used.

image https://ckb-explorer-frontend-in-nervosnetwork-re-git-a37ef3-magickbase.vercel.app/en/address/ckt1qzda0cr08m85hc8jlnfp3zer7xulejywt49kt2rr0vthywaa50xwsqfu3lmcwpamxg83khzffjv2parysr5sgxc8a4f4x image 2、`Capacity` information is missing in `UDT`Tab list view.

@Sven-TBD 2. UDT does not have capacity field.
image

@Sven-TBD
Copy link

https://ckb-explorer-frontend-in-nervosnetwork-re-git-a37ef3-magickbase.vercel.app/en/address/ckt1qrejnmlar3r452tcg57gvq8patctcgy8acync0hxfnyka35ywafvkqgjvmm4mjsafx7etwzhn5d3vun6sxpeexruqq2sgnfp image 1、When the data is empty, the / symbol needs to be used.
image
https://ckb-explorer-frontend-in-nervosnetwork-re-git-a37ef3-magickbase.vercel.app/en/address/ckt1qzda0cr08m85hc8jlnfp3zer7xulejywt49kt2rr0vthywaa50xwsqfu3lmcwpamxg83khzffjv2parysr5sgxc8a4f4x image 2、Capacity information is missing in UDTTab list view.

@Sven-TBD 2. UDT does not have capacity field. image

Every UDT Cells have attribution of capacity, however the UDT here is a statistic value, so it doesn't own an attribution of capacity, It's ok to display without it.
Originally speaking ,it's designed for the users to focus more on the USDT value rather than the CKB capacity on this tab

@FrederLu
Copy link

https://ckb-explorer-frontend-in-nervosnetwork-re-git-a37ef3-magickbase.vercel.app/en/address/ckt1qrejnmlar3r452tcg57gvq8patctcgy8acync0hxfnyka35ywafvkqgjvmm4mjsafx7etwzhn5d3vun6sxpeexruqq2sgnfp image 1、When the data is empty, the / symbol needs to be used.
image
https://ckb-explorer-frontend-in-nervosnetwork-re-git-a37ef3-magickbase.vercel.app/en/address/ckt1qzda0cr08m85hc8jlnfp3zer7xulejywt49kt2rr0vthywaa50xwsqfu3lmcwpamxg83khzffjv2parysr5sgxc8a4f4x image 2、Capacity information is missing in UDTTab list view.

@Sven-TBD 2. UDT does not have capacity field. image

Every UDT Cells have attribution of capacity, however the UDT here is a statistic value, so it doesn't own an attribution of capacity, It's ok to display without it. Originally speaking ,it's designed for the users to focus more on the USDT value rather than the CKB capacity on this tab

Hi @Keith-CY , this PR has been verified.

@Keith-CY Keith-CY merged commit d9c1050 into nervosnetwork:develop May 29, 2024
2 checks passed
@Keith-CY Keith-CY deleted the feature/list-view branch May 29, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants