Skip to content

Commit b65db07

Browse files
authored
Rewrite internal/retrieval/test_attributes.py (#131)
Also, remove unnecessary auto-used fixture
1 parent 78c66b5 commit b65db07

File tree

4 files changed

+225
-168
lines changed

4 files changed

+225
-168
lines changed

tests/e2e/data_ingestion.py

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,11 @@
2424
import neptune_scale.types
2525
from neptune_api import AuthenticatedClient
2626

27-
Histogram = neptune_scale.types.Histogram
28-
File = neptune_scale.types.File
27+
IngestionHistogram = neptune_scale.types.Histogram
28+
IngestionFile = neptune_scale.types.File
2929

3030

31-
SeriesPoint = TypeVar("SeriesPoint", str, float, Histogram, File)
31+
SeriesPoint = TypeVar("SeriesPoint", str, float, IngestionHistogram, IngestionFile)
3232

3333

3434
_STEP0_TIMESTAMP = 1_700_000_000.0 # Arbitrary fixed timestamp for ingestion start
@@ -56,12 +56,15 @@ class RunData:
5656
fork_point: tuple[str, float] | None = None
5757

5858
configs: dict[str, int | str] | None = field(default_factory=dict)
59-
files: dict[str, File] | None = field(default_factory=dict)
59+
files: dict[str, IngestionFile] | None = field(default_factory=dict)
6060

6161
float_series: dict[str, dict[float, float]] = field(default_factory=dict)
6262
string_series: dict[str, dict[float, str]] = field(default_factory=dict)
63-
histogram_series: dict[str, dict[float, Histogram]] = field(default_factory=dict)
64-
file_series: dict[str, dict[float, File]] = field(default_factory=dict)
63+
histogram_series: dict[str, dict[float, IngestionHistogram]] = field(default_factory=dict)
64+
file_series: dict[str, dict[float, IngestionFile]] = field(default_factory=dict)
65+
66+
# string set attributes (logged as tags)
67+
string_sets: dict[str, list[str]] | None = field(default_factory=dict)
6568

6669

6770
def get_all_steps(run_data: RunData) -> Iterable[float]:
@@ -112,7 +115,7 @@ class IngestedRunData:
112115
configs: dict[str, int | str]
113116
float_series: dict[str, dict[float, float]]
114117
string_series: dict[str, dict[float, str]]
115-
histogram_series: dict[str, dict[float, Histogram]]
118+
histogram_series: dict[str, dict[float, IngestionHistogram]]
116119

117120

118121
@dataclass(frozen=True)
@@ -233,6 +236,9 @@ def _ingest_runs(runs_data: list[RunData], api_token: str, project_identifier: s
233236
if run_data.configs:
234237
run.log_configs(run_data.configs)
235238

239+
if run_data.string_sets:
240+
run.log(tags_add=run_data.string_sets)
241+
236242
if run_data.files:
237243
run.assign_files(run_data.files)
238244

tests/e2e/internal/conftest.py

Lines changed: 0 additions & 6 deletions
This file was deleted.

0 commit comments

Comments
 (0)