Skip to content

Commit c063025

Browse files
authored
Remove inherit_configs as it's not universally avaialable yet (#326)
* Remove inherit_configs as it's not universally avaialable yet * Remove test too
1 parent a4d3b5f commit c063025

File tree

2 files changed

+0
-34
lines changed

2 files changed

+0
-34
lines changed

src/neptune_scale/api/run.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,6 @@ def __init__(
182182
enable_console_log_capture: bool = True,
183183
runtime_namespace: Optional[str] = None,
184184
source_tracking_config: Optional[SourceTrackingConfig] = SourceTrackingConfig(),
185-
inherit_configs: bool = True,
186185
**kwargs: Any,
187186
) -> None:
188187
"""
@@ -217,7 +216,6 @@ def __init__(
217216
runtime_namespace: Attribute path prefix for the captured logs. If not provided, defaults to "runtime".
218217
source_tracking_config: Change or disable the logging of source code and Git information. To specify what
219218
information to log, pass a `SourceTrackingConfig` object. To disable logging, set to `None`.
220-
inherit_configs:
221219
"""
222220

223221
if run_id is None:
@@ -400,7 +398,6 @@ def __init__(
400398
experiment_name=experiment_name,
401399
fork_run_id=fork_run_id,
402400
fork_step=fork_step,
403-
inherit_configs=inherit_configs,
404401
)
405402
self._write_source_tracking_attributes(source_tracking_config)
406403

@@ -539,7 +536,6 @@ def _create_run(
539536
experiment_name: Optional[str],
540537
fork_run_id: Optional[str],
541538
fork_step: Optional[Union[int, float]],
542-
inherit_configs: bool,
543539
) -> None:
544540
if self._operations_repo is None:
545541
logger.debug("Run is in mode that doesn't support creating runs.")
@@ -558,7 +554,6 @@ def _create_run(
558554
fork_point=fork_point,
559555
experiment_id=experiment_name,
560556
creation_time=None if creation_time is None else datetime_to_proto(creation_time),
561-
inherit_configs=inherit_configs,
562557
)
563558

564559
self._operations_repo.save_create_run(create_run)

tests/e2e/test_log_and_fetch.py

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -217,32 +217,3 @@ def test_source_tracking(run, client, project_name):
217217
assert file_ref["mime_type"] == "application/patch"
218218
assert file_ref["size_bytes"] == len(value)
219219
assert file_ref["path"] is not None
220-
221-
222-
@pytest.mark.parametrize(
223-
"inherit_configs",
224-
[True, False],
225-
)
226-
def test_inherit_configs(api_token, client, run, project_name, inherit_configs):
227-
# given
228-
now = time.time()
229-
data = {
230-
"int-value": int(now),
231-
"float-value": now,
232-
"str-value": f"hello-{now}",
233-
}
234-
run.log_configs(data)
235-
assert run.wait_for_processing(SYNC_TIMEOUT)
236-
237-
# when
238-
with Run(
239-
api_token=api_token, project=project_name, fork_run_id=run._run_id, fork_step=0, inherit_configs=inherit_configs
240-
) as run_2:
241-
pass
242-
243-
fetched = fetch_attribute_values(client, project_name, custom_run_id=run_2._run_id, attributes=data.keys())
244-
for key, value in data.items():
245-
if inherit_configs:
246-
assert fetched[key] == value, f"Value for {key} does not match"
247-
else:
248-
assert key not in fetched, f"Value for {key} was inherited but should not be"

0 commit comments

Comments
 (0)