Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify package version requirement using == instead of >= #384

Open
fp4code opened this issue Mar 30, 2021 · 1 comment
Open

Specify package version requirement using == instead of >= #384

fp4code opened this issue Mar 30, 2021 · 1 comment

Comments

@fp4code
Copy link

fp4code commented Mar 30, 2021

Description

Djangocms-installer djangocms command should install only working configurations with package versions requirement specified using == instead of >=.
Today, a djangocms mysite site is buggy due to django-cms/django-cms#6980

Steps to reproduce

mkdir test
cd test
python3 -m venv env
. env/bin/activate
pip install --upgrade pip
pip install djangocms-installer
djangocms mysite
cd mysite
./manage.py runserver
  • open http://localhost:8000/
  • connect admin/admin
  • create a page
  • create a subpage
  • insert a text content (it seems important to do that)
  • publish it
Internal Server Error: ... treebeard.exceptions.NodeAlreadySaved: Attempted to add a tree node that is already in the database

Versions

  • Python 3.8.6
  • Django==3.1.7
  • django-cms==3.8.0
  • django-treebeard==4.5.1

Expected behaviour

  • django-treebeard==4.4

Actual behaviour

  • django-treebeard==4.5.1

Additional information

The problem is more general, djangocms-installer should install only working configurations,
with == specifications written in djangocms_installer/config/data.py file instead of >= specifications.

Here django-cms==3.8.0 was working with django-treebeard==4.4, but is no more working since django-treebeard is upgraded to 4.5.1.

@yakky
Copy link
Member

yakky commented Jul 17, 2021

Using strict equality would generate a lot of maintenance burden on the package.

In cases like this it's much easier to restrict dependencies whenever an issue arise.

For treebeard it's actually sensible to restrict the version brackets and being more conservative.

I will open a PR for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants