Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tutor): add instruction to reload tutor ... #28175

Closed
wants to merge 1 commit into from

Conversation

goyalyashpal
Copy link

Problem: Any change to line numbers break the line-number based tests
from *.tutor.json. This is problematic for lessons involving
unbalanced line deletions or insertions.
Solution: Instruct to reload the tutor, thus discarding any edits.
Fortunately, only "Lesson 2.6: OPERATING ON LINES" involves
such line modifications. So, this is needed only there.

Closes: #28164

Problem: Any change to line numbers break the line-number based tests
        from *.tutor.json. This is problematic for lessons involving
        unbalanced line deletions or insertions.
Solution: Instruct to reload the tutor, thus discarding any edits.
        Fortunately, only "Lesson 2.6: OPERATING ON LINES" involves
        such line modifications. So, this is needed only there.

Closes: neovim#28164
@goyalyashpal goyalyashpal marked this pull request as draft April 4, 2024 16:05
@goyalyashpal
Copy link
Author

goyalyashpal commented Apr 4, 2024

Invalid commit message: "docs(tutor): add instruction to reload tutor ..."
Commit: df65fd9
Description ends with a period (".").
https://github.com/neovim/neovim/actions/runs/8557764439/job/23450794908#step:5:16

so, ellipsis are not used in commits with the optional body?
these seemed to help while git log --oneline on CLI etc.

just asking for confirmation before removing these

@justinmk
Copy link
Member

justinmk commented Apr 7, 2024

so, ellipsis are not used in commits with the optional body?

subject is different than body.

your subject ends with "..." , what is the point of that? just remove the "..."

@goyalyashpal
Copy link
Author

goyalyashpal commented May 11, 2024

your subject ends with "..." ,
what is the point of that?

using in git cli,

  • where there's no inbuilt hint regarding whether there's any further body to the commit message or not.
  • there, it's only these explicit ellipsis in commit title/subject which hint regarding "there's more here", otherwise all look same
  • what's more, i think that the ... button on GUIs of github etc is inspired from this convention itself

see below:

i picked this style from some git-commit message guide some time ago.

$ git log --oneline -n4 --no-decorate
6ae778857 theia: Add version 1.49.1 ...           <~~~
d48d63f0b q-dir: Update to version 11.64
84c3acc8d peazip: Update to version 9.8.0
57301172f notesnook: Update to version 3.0.4

@justinmk
Copy link
Member

Do you plan to finish this? The details about git are off topic.

@justinmk justinmk added the needs:response waiting for reply from the author label May 11, 2024
@goyalyashpal
Copy link
Author

Do you plan to finish this?

😆 oh lol.

  • i had shared all my investigation and conclusion as far back as 2024.04.04 (more than a month ago).
  • infact, i was awaiting ur response 😅. u asked me to update, which i did. but nobody never answered even then.

just to iterate here again:

  • the only feasible way i could think of to solve this is to reload the tutor,
  • and i didn't get any response on how can that be done!

Verbatim quoting:

hi @ justinmk
is it possible to reload/revert the tutor?

  • following this: edit-a-file, i tried doing :e! inside the :Tutor, and it showed me blank. ...
  • i even tried rerunning :Tutor inside :Tutor, but again showed me blank.

do you have any other thoughts?

- me at #28164 (comment)

@github-actions github-actions bot removed the needs:response waiting for reply from the author label May 11, 2024
@justinmk
Copy link
Member

This is way too much complication for what appears to be a small problem. Either send a PR that fixes it or it's wontfix.

@justinmk justinmk closed this May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tutor tests become unresponsive on line-number mismatch
2 participants