Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interface{} -> any #176

Closed
garyburd opened this issue May 14, 2024 · 2 comments · Fixed by #178
Closed

interface{} -> any #176

garyburd opened this issue May 14, 2024 · 2 comments · Fixed by #178

Comments

@garyburd
Copy link
Contributor

Replace uses of interface{} in the code with the alias any.

Steps:

  1. Run gofmt -w -s . at the root of the project.
  2. Hand edit comments and string literals to replace interface{} with any. The templates in nvim/api_tool.go are a notable example of where hand editing is required.
  3. Run go generate.

This change can create merge conflicts for work in progress. Should this change wait on any work in progress?

@justinmk
Copy link
Member

Should this change wait on any work in progress?

The only non-trivial open PR is #95 and it doesn't look like it will be hard to adapt to this change. @zchee

@zchee
Copy link
Member

zchee commented May 14, 2024

@garyburd go ahead to will conflicts change. I can following your (repository) upstream change anytime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants